fix: add setuptools and wheel to default sdist build dependencies#1103
Draft
xangcastle wants to merge 1 commit into
Draft
fix: add setuptools and wheel to default sdist build dependencies#1103xangcastle wants to merge 1 commit into
xangcastle wants to merge 1 commit into
Conversation
✨ Aspect Workflows Tasks📅 Thu Jun 11 12:49:24 UTC 2026 ❌ 2 failed tasks
✅ 5 successful tasks
🔁 Reproduce❌ test (test-e2e-bazel-8 · test-e2e-bazel-9)Install ⏱ Last updated Thu Jun 11 13:26:05 UTC 2026 · 📊 GitHub API quota 479/15,000 (3% used, resets in 45m, throttle 3×) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects using setuptools.build_meta as their sdist build backend require both setuptools and wheel to be available during the PEP 517 build, but the default_build_dependencies list only shipped build, causing silent failures for any project that didn't explicitly override the list. This adds setuptools and wheel to the default, covering the overwhelmingly common case; the existing uv-sdist-native-build e2e test (python-geohash, a C-extension sdist built with setuptools) now relies on this default instead of an explicit override, so any future regression against these defaults will fail CI directly.
Changes are visible to end-users: no
Test plan