Skip to content

fix: add setuptools and wheel to default sdist build dependencies#1103

Draft
xangcastle wants to merge 1 commit into
1.xfrom
fix/sdist-default-build-deps
Draft

fix: add setuptools and wheel to default sdist build dependencies#1103
xangcastle wants to merge 1 commit into
1.xfrom
fix/sdist-default-build-deps

Conversation

@xangcastle

Copy link
Copy Markdown
Member

Projects using setuptools.build_meta as their sdist build backend require both setuptools and wheel to be available during the PEP 517 build, but the default_build_dependencies list only shipped build, causing silent failures for any project that didn't explicitly override the list. This adds setuptools and wheel to the default, covering the overwhelmingly common case; the existing uv-sdist-native-build e2e test (python-geohash, a C-extension sdist built with setuptools) now relies on this default instead of an explicit override, so any future regression against these defaults will fail CI directly.


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@aspect-workflows

aspect-workflows Bot commented Jun 11, 2026

Copy link
Copy Markdown

✨ Aspect Workflows Tasks

📅 Thu Jun 11 12:49:24 UTC 2026

❌ 2 failed tasks

  • ❌ test (test-e2e-bazel-8) · ⏱ 34.5s · 🐙 GitHub Actions · ☑️ Check
    💬 failed in test · Bazel test failed
  • ❌ test (test-e2e-bazel-9) · ⏱ 23s · 🐙 GitHub Actions · ☑️ Check
    💬 failed in test · Bazel test failed

✅ 5 successful tasks

  • ✅ buildifier · ⏱ 20.2s · 🐙 GitHub Actions · ☑️ Check
    💬 Format complete (clean)
  • ✅ gazelle · ⏱ 19.1s · 🐙 GitHub Actions · ☑️ Check
    💬 Gazelle complete (clean)
  • ✅ test (test-examples-uv_pip_compile-bazel-8) · ⏱ 22.5s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed · 1 cached)
  • ✅ test (test-root-bazel-8) · ⏱ 36m 33s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (123/123 passed)
  • ✅ test (test-root-bazel-9) · ⏱ 36m 27s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (122/122 passed)

🔁 Reproduce

❌ test (test-e2e-bazel-8 · test-e2e-bazel-9)

aspect test -- //...
# without Aspect CLI
bazel test -- //...

Install aspect: docs.aspect.build/cli/install


⏱ Last updated Thu Jun 11 13:26:05 UTC 2026 · 📊 GitHub API quota 479/15,000 (3% used, resets in 45m, throttle 3×)
🚀 Powered by Aspect CLI (v2026.22.44)  |  Aspect Build · X · LinkedIn · YouTube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant