MAINT: some TLC for old versions#3585
Open
bsipocz wants to merge 3 commits intoastropy:mainfrom
Open
Conversation
Member
Author
|
Just for cross references, we may need to look into astropy/sphinx-automodapi#119 and the workaround used by spacetelescope/roman_datamodels#156? |
65eaa25 to
47f2065
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3585 +/- ##
=======================================
Coverage 73.22% 73.22%
=======================================
Files 226 226
Lines 21000 21000
=======================================
Hits 15378 15378
Misses 5622 5622 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We run into a couple of easy to fix issues while investigating #3584
I still have issues directly running
sphinx-buildin some old python env, but all those python versions do work for me™️ withtox -e build_docs, so I stopped investigating further.(typical flavour of the failure I see is automodapi related with something like this:
I would say it probably wouldn't hurt to find and declare minimum sphinx and sphinx extension versions, too.