Skip to content

MAINT: some TLC for old versions#3585

Open
bsipocz wants to merge 3 commits intoastropy:mainfrom
bsipocz:MAINT_old_version_care
Open

MAINT: some TLC for old versions#3585
bsipocz wants to merge 3 commits intoastropy:mainfrom
bsipocz:MAINT_old_version_care

Conversation

@bsipocz
Copy link
Copy Markdown
Member

@bsipocz bsipocz commented Apr 30, 2026

We run into a couple of easy to fix issues while investigating #3584

I still have issues directly running sphinx-build in some old python env, but all those python versions do work for me™️ with tox -e build_docs, so I stopped investigating further.

(typical flavour of the failure I see is automodapi related with something like this:

Handler <function process_automodsumm_generation at 0x123f96f80> for event 'builder-inited' threw an exception (exception: No module named 'astroquery.esa.integral')

I would say it probably wouldn't hurt to find and declare minimum sphinx and sphinx extension versions, too.

@bsipocz
Copy link
Copy Markdown
Member Author

bsipocz commented Apr 30, 2026

Just for cross references, we may need to look into astropy/sphinx-automodapi#119 and the workaround used by spacetelescope/roman_datamodels#156?

@bsipocz bsipocz force-pushed the MAINT_old_version_care branch from 65eaa25 to 47f2065 Compare April 30, 2026 17:42
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.22%. Comparing base (a1fee2a) to head (47f2065).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3585   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files         226      226           
  Lines       21000    21000           
=======================================
  Hits        15378    15378           
  Misses       5622     5622           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant