Skip to content

MAST: MastMissions improvements#3588

Open
snbianco wants to merge 2 commits intoastropy:mainfrom
snbianco:subscription-mission
Open

MAST: MastMissions improvements#3588
snbianco wants to merge 2 commits intoastropy:mainfrom
snbianco:subscription-mission

Conversation

@snbianco
Copy link
Copy Markdown
Contributor

@snbianco snbianco commented May 7, 2026

This PR includes some improvements for our MastMissions class:

  • Results returned from MastMissions metadata query functions now include search parameters in the metadata of the astropy.table.Table object and column descriptions in the column metadata.
  • Added pass_id as an alias for the Roman mission's pass column in query functions to avoid conflicts with
    the reserved Python keyword.
  • Refactored download_products so that when a user inputs a JSON file from the subscription service, the value of mission is taken from the data. This will allow users to download products from multiple missions in a single call.
  • Fix in our test_mast.py file where a directory was being created outside of the test environment.

@snbianco snbianco added the mast label May 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.23%. Comparing base (e3702c4) to head (a0ec925).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/mast/missions.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3588   +/-   ##
=======================================
  Coverage   73.22%   73.23%           
=======================================
  Files         226      226           
  Lines       21000    21010   +10     
=======================================
+ Hits        15378    15386    +8     
- Misses       5622     5624    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snbianco
Copy link
Copy Markdown
Contributor Author

snbianco commented May 7, 2026

For your awareness: @sedonaprice @bmorris3 @ttdu

@snbianco snbianco marked this pull request as ready for review May 7, 2026 18:44
@snbianco snbianco requested a review from bsipocz May 7, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant