Upgrade PyPI CI publishing to use Trusted Publishing#661
Open
lmmx wants to merge 1 commit intoastropy:mainfrom
Open
Upgrade PyPI CI publishing to use Trusted Publishing#661lmmx wants to merge 1 commit intoastropy:mainfrom
lmmx wants to merge 1 commit intoastropy:mainfrom
Conversation
This was referenced May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates PyPI publishing from a long-lived API token to Trusted Publishing (OIDC), motivated by recent supply chain attacks (litellm, lightning).
The publishing step uses a reusable workflow from the OpenAstronomy org, and since you can't pass OIDC tokens across orgs, the workaround (documented here) is to instead set
upload_to_pypi: falseandsave_artifacts: truethen publish the stored artifact with thepypa/gh-action-pypiaction. I followed this example from the astropy package repo.The code changes here require some further (trivial) setup on the PyPI-side. Specifically, the PyPI admin (not just maintainer) needs to register the TP on PyPI at https://pypi.org/manage/project/regions/settings/publishing/
astropyregionspublish.ymlpypiThe
pypi_tokensecret should be deleted from the repo secrets and can be invalidated on PyPI too.(Not sure who is the PyPI admin, the maintainers are listed as @keflavich @larrybradley @astrofrog)