Adds a flag for returning the model spectra for SDSS BHM spec files - #1339
Open
havok2063 wants to merge 3 commits into
Open
Adds a flag for returning the model spectra for SDSS BHM spec files#1339havok2063 wants to merge 3 commits into
havok2063 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
modelflag to the loader for SDSS BHM spec files to optionally return the model spectrum. The model is stored as a separate column in the same table with the flux spectrum. This flag sets the model data as the Spectrum "flux". There is an added metadata boolean keywordis_modelwhether the returned Spectrum object is a model or not. This is a placeholder implementation until specutils adds support for model spectra.Pinging @albireox for review as well.