DEVPROD-3580: Add gateway api support#1084
Merged
pbhardwaj6 merged 23 commits intomainfrom Apr 3, 2026
Merged
Conversation
…port' into DEVPROD-3580-add-gateway-api-support # Conflicts: # .github/workflows/kind.yaml # .github/workflows/openshift.yaml # src/test/java/test/GatewayTest.java
Member
|
@pbhardwaj6 this is fairly large PR (46 files), can you please supply PR description and testing notes? |
kush982
reviewed
Feb 23, 2026
3 tasks
amierzwicki
reviewed
Mar 9, 2026
amierzwicki
reviewed
Mar 9, 2026
* DEVPROD-3580 Extracted and re-used common logic. * DEVPROD-3580 Improved documentation.
amierzwicki
reviewed
Mar 11, 2026
amierzwicki
reviewed
Mar 11, 2026
amierzwicki
reviewed
Mar 11, 2026
amierzwicki
reviewed
Mar 11, 2026
amierzwicki
reviewed
Mar 11, 2026
amierzwicki
reviewed
Mar 11, 2026
amierzwicki
reviewed
Mar 11, 2026
|
|
||
| // When Synchrony is enabled, Confluence creates an extra rule. | ||
| // We just validate it points at the synchrony Service. | ||
| assertThat(httpRoute.getNode("spec", "rules").required(0) |
Collaborator
There was a problem hiding this comment.
It probably would be wise to also check that product route is at the position 1 - just to eliminate case where we accidentally override product route instead of prepending it with synchrony route.
Contributor
Author
There was a problem hiding this comment.
ok, will do the update
amierzwicki
reviewed
Mar 11, 2026
amierzwicki
reviewed
Mar 11, 2026
amierzwicki
requested changes
Mar 11, 2026
Collaborator
amierzwicki
left a comment
There was a problem hiding this comment.
Nice work! I've left few suggestions. We need to get the tests passing on this one.
amierzwicki
reviewed
Mar 17, 2026
amierzwicki
reviewed
Mar 17, 2026
amierzwicki
reviewed
Mar 17, 2026
amierzwicki
reviewed
Mar 17, 2026
amierzwicki
reviewed
Mar 17, 2026
amierzwicki
reviewed
Mar 17, 2026
amierzwicki
reviewed
Mar 17, 2026
1 task
…way-api-support # Conflicts: # src/main/charts/confluence/Chart.yaml # src/test/resources/expected_helm_output/confluence/output.yaml # src/test/scripts/kind/deploy_app.sh
…nfig across products.
…way-api-support # Conflicts: # src/main/charts/bamboo/Chart.yaml # src/main/charts/bitbucket/Chart.yaml # src/main/charts/crowd/Chart.yaml # src/main/charts/jira/Chart.yaml
amierzwicki
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request description
This change is because of nginx is going out of support in march. Ref: https://www.kubernetes.dev/blog/2025/11/12/ingress-nginx-retirement/
Summary
Key Changes
Helm charts (Bamboo/Bitbucket/Confluence/Crowd/Jira)
Functional tests / CI
How It Works (Gateway Mode)
Testing Notes
Checklist
e2elabel)Upgrade to Rovo Dev Standard to continue using code review.