fix(common): stabilize pnp service startup#204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Таска
Как проверять
До фикса
Контекст: Docker/Raijin PnP startup для backend сервисов Serenity.
Действие: запустить
portfolioчерез штатныйyarn service devв compose-контуре.Ожидаемый результат: сервис падает до старта Nest из-за
pg@7.13.0, который пытается загрузить undeclaredpg-nativeпод PnP.Контекст: Docker/Raijin PnP startup для
files-service.Действие: запустить
files-serviceчерез штатныйyarn service devв compose-контуре.Ожидаемый результат: Nest не может собрать
UploadService, потому что@files/applicationи@files/persistenceрезолвятся как разные virtual package instances.После фикса
Контекст: repo-managed Yarn/PnP dependency contour.
Действие:
yarn install --immutable.Ожидаемый результат: команда проходит, остаются только legacy peer/packageExtensions warnings.
Контекст: Docker/Raijin PnP startup основных backend/gateway сервисов.
Действие: запустить one-off smoke через compose и штатный
yarn service devдля сервисов.Ожидаемый результат:
portfolio,search-service,files-service,public-gateway,private-gatewayстартуют без PnP/Nest runtime падений.Пруфы
yarn install --immutableportfolioDocker smokesearch-serviceDocker smokefiles-serviceDocker smokepublic-gatewayDocker smokeprivate-gatewayDocker smoke