Conversation
Instead of using login shell, prefer current $SHELL.
Greptile SummarySmall fix that prefers
Important Files Changed
Reviews (1): Last reviewed commit: "feat(atuin hex): allow subshell spawn to..." | Re-trigger Greptile |
Simply fallback to login shell.
There was a problem hiding this comment.
Thank you for the work here! I'm not sure this makes sense to override it - typically, $SHELL is set to the login shell, and while it could make sense to allow the user to override it to change what hex launches, it may then affect anything running within hex that might expect that to remain true
In this case, I think we'd be better off allowing the user to provide --shell to hex, and pass in a path to launch
|
That sounds good to me. Let me try to update this PR |
|
Hey any progress on this or a workaround for nushell? |
Greetings, I am open to an alternative solution like subcommand support or something else which I am happy to accomodate.
Fixes #3326.
Checks