Open
Conversation
Closes atuinsh#3046 Signed-off-by: Bruno Verachten <gounthar@gmail.com>
Contributor
Greptile SummaryAdds
Important Files Changed
Reviews (1): Last reviewed commit: "ci: add riscv64gc-unknown-linux-gnu to c..." | Re-trigger Greptile |
| aarch64-unknown-linux-musl = "depot-ubuntu-24.04-arm-8" | ||
| riscv64gc-unknown-linux-gnu = "ubuntu-24.04-riscv" | ||
| x86_64-unknown-linux-gnu = "depot-ubuntu-24.04-8" | ||
| x86_64-unknown-linux-musl = "depot-ubuntu-24.04-8" |
Contributor
There was a problem hiding this comment.
Blocking risk if RISE app isn't installed
If the RISE RISC-V Runners app is not installed on atuinsh/atuin, any release triggered will hang indefinitely waiting for the ubuntu-24.04-riscv runner — potentially blocking the entire release workflow.
Has the app been installed on this repository before merging?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds riscv64gc-unknown-linux-gnu to the cargo-dist targets in dist-workspace.toml, with ubuntu-24.04-riscv as the custom runner.
The release workflow reads targets dynamically via
dist plan, so no workflow changes needed.RISE runners are provided by the RISE Project (https://riseproject.dev/), free for open source. To enable: install https://github.com/apps/rise-risc-v-runners on this repository. Without it, the riscv64 job stays queued with no runner.
Build validated on native riscv64: https://github.com/gounthar/atuin/actions/runs/23430141128
Closes #3046