Skip to content

fix: minor issues with fish's vim mode(s) #3362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rightaditya wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −2
Open

fix: minor issues with fish's vim mode(s) #3362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
216b63c
fix: AI fish keybind inserts `?` in non-insert vi modes
rightaditya Mar 30, 2026
ca6ccac
fix: Detect both vim modes included in fish
rightaditya Mar 30, 2026
7b5dff7
invert vim mode check
rightaditya Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/atuin-ai/src/commands/init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ function _atuin_ai_question_mark
else
commandline -f repaint
end
else
else if not contains -- "$fish_key_bindings" fish_vi_key_bindings fish_hybrid_key_bindings
# Not at empty prompt, just insert the question mark
commandline -i "?"
end
Expand Down
2 changes: 1 addition & 1 deletion crates/atuin/src/shell/atuin.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ end
function _atuin_search
set -l keymap_mode
switch $fish_key_bindings
case fish_vi_key_bindings
case fish_vi_key_bindings fish_hybrid_key_bindings
switch $fish_bind_mode
case default
set keymap_mode vim-normal
Expand Down