RAID-731: Skip DataCite error test when mockserver unavailable#564
Merged
Conversation
The test previously created a mockserver expectation dynamically at runtime, which failed with connection refused in the Branch-Build-Deploy pipeline where no Docker stack runs. The DataCite 429 expectation is now defined statically in expectations.json (matched by a sentinel string in the raid title, priority 10 over the generic 201 expectations), and the test skips via JUnit Assumptions when mockserver at localhost:1080 is unreachable. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Abdul-ardc
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-lands the RAID-731 fix for
DataciteErrorIntegrationTestontomain(cherry-pick ofba56b5f5).The test previously programmed a MockServer expectation at runtime via a hardcoded
http://localhost:1080/mockserver/expectation. In theBranch-Build-Deploypipeline no Docker stack runs, so that call fails with connection refused during test setup, failingintTestfor the whole branch. This change defines the DataCite 429 expectation statically indocker-compose/mockserver/expectations.json(matched by a sentinel string in the raid title, priority 10 over the generic 201 expectations) and skips the test via JUnitAssumptionswhen MockServer atlocalhost:1080is unreachable.Why this PR exists
The fix was originally raised as PR #560, which was closed without merging. The commit only survived on the unmerged RAID-712 branch (PR #558), so
mainnever received it. As a result every branch cut frommainstill runs the old hardcoded test and failsintTestin Branch-Build-Deploy — most recently thefeature/RAID-733executioncd33496f-48bc-4d32-83ac-4cc2ea5a6912, where this was the only failing test (165/166 passed).This PR decouples the test fix from the larger RAID-712 feature and lands it on
maindirectly so all branch pipelines are unblocked.Verification
main../gradlew :api-svc:raid-api:compileIntTestJavasucceeds (warnings only).🤖 Generated with Claude Code