Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 96.78% 96.59% -0.20%
==========================================
Files 37 38 +1
Lines 2958 2965 +7
==========================================
+ Hits 2863 2864 +1
- Misses 95 101 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've gotten multiple user reports now that previews have "hung" and not completed. This is definitely an issue with the Celery worker.
Looking in the worker logs, I see:
It seems like it's losing the connection to the Upstash Redis. In this PR, I've attempted to stop using a worker pool (so connections don't get stale), use infinite retries, and retry on startup.
Hopefully this will fix the issue.