refactor(ebpf): use AsyncFd in PerfEventReader#601
Merged
Conversation
mccormickt
force-pushed
the
push-rpslkxrysktu
branch
from
49392d8 to
e7527e4
Compare
mccormickt
commented
May 8, 2026
| * Distributed Systems Runtime * | ||
| * -------------------------------------------------------------------------- * | ||
| * Copyright 2022 - 2024, the aurae contributors * | ||
| * SPDX-License-Identifier: Apache-2.0 * |
Contributor
Author
There was a problem hiding this comment.
Maybe we need to adapt this header for the code since it must be GPL-compatible? Cillium (Apache 2.0) has their ebpf code licensed Dual BSD/GPL, for example.
Contributor
There was a problem hiding this comment.
it looks like your change here is removing the GPL-2.0 and MIT license identifiers that were here for exactly that reason. (it was dual license MIT/GPL2.0 prior to this PR)
Contributor
Author
There was a problem hiding this comment.
Reverted. Limited this change to just the tokio-compat and left the headers and licenses as they were.
mccormickt
force-pushed
the
push-rpslkxrysktu
branch
from
e7527e4 to
001f6bc
Compare
dmah42
reviewed
May 8, 2026
| * Copyright 2022 - 2024, the aurae contributors * | ||
| * SPDX-License-Identifier: Apache-2.0 * | ||
| \* -------------------------------------------------------------------------- */ | ||
| /* -------------------------------------------------------------------------- *\ |
Contributor
There was a problem hiding this comment.
same here.. don't remove this :)
Contributor
Author
There was a problem hiding this comment.
Gotcha - thought this was just a double-header mistake.
dmah42
reviewed
May 8, 2026
| * Copyright 2022 - 2024, the aurae contributors * | ||
| * SPDX-License-Identifier: Apache-2.0 * | ||
| \* -------------------------------------------------------------------------- */ | ||
| /* -------------------------------------------------------------------------- *\ |
…ion as `AsyncPerfEventArray` is removed
mccormickt
force-pushed
the
push-rpslkxrysktu
branch
from
001f6bc to
786e0eb
Compare
dmah42
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncPerfEventArrayand the accompanyingasync_tokiois removed in future versions ofaya. This change refactors ourPerfBufferReaderto use anAsyncFdfor async support to reduce friction in migrating to a future release.aya-rs/aya#1292