Extract react-router-dom from #194 (Fixes #215)#312
Closed
rovidev95 wants to merge 10 commits into
Closed
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ed, WithdrawFromPrivate Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ffith#179) Co-authored-by: Cursor <cursoragent@cursor.com>
…kfile. - Fixes austintgriffith#200: applyPathFromScan avoids full page reload on QR scan - Fixes austintgriffith#170: incognito detection, warning banner, PK backup on tab close - Fixes austintgriffith#212: document special URL schemes in docs/SPECIAL_URLS.md - Fixes austintgriffith#208: git branching guide in docs/BRANCHING.md - Fixes austintgriffith#216: commit package-lock.json (remove from .gitignore) - Fixes austintgriffith#228: GitHub Actions CI workflow for tests - Partial austintgriffith#205: Dependabot + check-pinned-deps script in CI
…ionStore or config.js. Fixes austintgriffith#215 - Add react-router-dom@5 and Container.js (BrowserRouter shell) - withRouter(App): changeView uses history.push; back/forward via history.listen - resolveViewFromPath maps /exchange, /send_to_address, legacy 0x;amount URLs - docs/ROUTING.md documents scope and intentional omissions from austintgriffith#194 Does NOT include config.js or TransactionStore per bounty scope.
Author
4 tasks
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts react-router-dom functionality from PR #194 per #215, deliberately excluding
config.jsandTransactionStore.Fixes #215
Changes
react-router-dom@5+src/Container.js(BrowserRouter,I18nextProvider)withRouter(App):changeView→history.push, browser back/forward viahistory.listenresolveViewFromPath()maps/exchange,/send_to_address, legacy0x…;amountURLsdocs/ROUTING.md— scope and follow-up notesAlgora
/claim #215 rovidev95@gmail.com
Test plan
/exchangeloads exchange view/{addr};{amount}still opens send flowapplyPathFromUrl)Builds on #311 batch. @TimDaub