fix(links): use toWei for large send-with-link amounts (Fixes #240)#322
Open
rovidev95 wants to merge 1 commit into
Open
fix(links): use toWei for large send-with-link amounts (Fixes #240)#322rovidev95 wants to merge 1 commit into
rovidev95 wants to merge 1 commit into
Conversation
…griffith#240) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #240
Problem
amount * 10**18produces scientific notation for large native sends (e.g. 20,000 xDAI), breaking BN conversion in send-with-link.Fix
Use
web3.utils.toWei(String(amount), 'ether')for link deposit value and tx value.Test plan
number-to-bninvalid valueStacks on
rim(same target branch as #204/#315 series). @TimDaub