Skip to content

Exclude ROM disable PXE boot tests on aarch64 - #6860

Merged
crobinso merged 1 commit into
autotest:masterfrom
hholoubk:fix/exclude-rom-disable-pxe-boot-aarch64
Sep 14, 2026
Merged

crobinso merged 1 commit into
autotest:masterfrom
hholoubk:fix/exclude-rom-disable-pxe-boot-aarch64

Conversation

@hholoubk

@hholoubk hholoubk commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator

All 18 virtual_network.rom.disable_pxe_boot test variants fail on aarch64 due to architecture incompatibilities in the test configuration:

  • seabios variants (6): SeaBIOS firmware does not exist on aarch64, causing "Unable to get vm!" errors.
  • uefi variants (6): The os_attrs hardcode machine type 'q35', but aarch64 requires 'virt', causing "Unable to find 'efi' firmware that is compatible with the current configuration" errors.

The remaining 6 variants (rom_bar_off) are already in the CI skiplist for aarch64 with the reason "Feature 'ROM tuning' is not supported on aarch64 machine".

Since none of the 18 tests have ever passed on aarch64 and all pass on x86_64, exclude the entire test from aarch64 at the cfg level, consistent with the existing s390-virtio exclusion.

Polarion: VIRT-296326

Made-with: Cursor
Signed-off-by: hholoubk hholoubk@redhat.com

Summary by CodeRabbit

  • Tests
    • Updated test configuration to exclude aarch64 architecture from certain virtual network interface tests.

All 18 virtual_network.rom.disable_pxe_boot test variants fail on
aarch64 due to architecture incompatibilities in the test
configuration:

- seabios variants (6): SeaBIOS firmware does not exist on aarch64,
  causing "Unable to get vm!" errors.
- uefi variants (6): The os_attrs hardcode machine type 'q35', but
  aarch64 requires 'virt', causing "Unable to find 'efi' firmware
  that is compatible with the current configuration" errors.

The remaining 6 variants (rom_bar_off) are already in the CI
skiplist for aarch64 with the reason "Feature 'ROM tuning' is not
supported on aarch64 machine".

Since none of the 18 tests have ever passed on aarch64 and all pass
on x86_64, exclude the entire test from aarch64 at the cfg level,
consistent with the existing s390-virtio exclusion.

Polarion: VIRT-296326

Signed-off-by: hholoubk <hholoubk@redhat.com>
Made-with: Cursor
@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3b9014ec-fb34-411c-9434-119337657273

📥 Commits

Reviewing files that changed from the base of the PR and between c96ab65 and 1231089.

📒 Files selected for processing (1)
  • libvirt/tests/cfg/virtual_network/rom/iface_rom_disable_pxe_boot.cfg

Walkthrough

A single exclusion constraint (no aarch64) is added to a test configuration file to prevent the iface_rom_disable_pxe_boot test from running on aarch64 architecture. The change affects only this specific test configuration without modifying any test logic, firmware variants, or interface/model/ROM settings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Exclude ROM disable PXE boot tests on aarch64' clearly and specifically describes the main change: adding an aarch64 exclusion to the iface_rom_disable_pxe_boot test configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hholoubk

Copy link
Copy Markdown
Collaborator Author

@smitterl could you please review this change it is simple remove of nonrelevant cases for aarch64 that never passed after this test was added for x86. thank you

@harvey0100

Copy link
Copy Markdown

Closing this PR due to current team constraints. This is part of a broader effort to triage all in-flight work across our upstream repos. If this work is still needed, please feel free to reopen and it will be picked up. Apologies for any inconvenience.

@harvey0100 harvey0100 closed this Jun 4, 2026
@hholoubk hholoubk reopened this Sep 9, 2026
@crobinso
crobinso merged commit e813a3b into autotest:master Sep 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants