Exclude ROM disable PXE boot tests on aarch64 - #6860
Conversation
All 18 virtual_network.rom.disable_pxe_boot test variants fail on aarch64 due to architecture incompatibilities in the test configuration: - seabios variants (6): SeaBIOS firmware does not exist on aarch64, causing "Unable to get vm!" errors. - uefi variants (6): The os_attrs hardcode machine type 'q35', but aarch64 requires 'virt', causing "Unable to find 'efi' firmware that is compatible with the current configuration" errors. The remaining 6 variants (rom_bar_off) are already in the CI skiplist for aarch64 with the reason "Feature 'ROM tuning' is not supported on aarch64 machine". Since none of the 18 tests have ever passed on aarch64 and all pass on x86_64, exclude the entire test from aarch64 at the cfg level, consistent with the existing s390-virtio exclusion. Polarion: VIRT-296326 Signed-off-by: hholoubk <hholoubk@redhat.com> Made-with: Cursor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA single exclusion constraint ( Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@smitterl could you please review this change it is simple remove of nonrelevant cases for aarch64 that never passed after this test was added for x86. thank you |
|
Closing this PR due to current team constraints. This is part of a broader effort to triage all in-flight work across our upstream repos. If this work is still needed, please feel free to reopen and it will be picked up. Apologies for any inconvenience. |
All 18 virtual_network.rom.disable_pxe_boot test variants fail on aarch64 due to architecture incompatibilities in the test configuration:
The remaining 6 variants (rom_bar_off) are already in the CI skiplist for aarch64 with the reason "Feature 'ROM tuning' is not supported on aarch64 machine".
Since none of the 18 tests have ever passed on aarch64 and all pass on x86_64, exclude the entire test from aarch64 at the cfg level, consistent with the existing s390-virtio exclusion.
Polarion: VIRT-296326
Made-with: Cursor
Signed-off-by: hholoubk hholoubk@redhat.com
Summary by CodeRabbit