Refactor buf modules#4083
Conversation
| - uses: actions/checkout@v4 | ||
| - uses: bufbuild/buf-action@dfda68eacb65895184c76b9ae522b977636a2c47 #v1.1.4 | ||
| with: | ||
| input: "proto" |
There was a problem hiding this comment.
Upon making changes to our CI I think there was a miss and we need another github action to run the linter on the connect module as a follow-up to this.
There was a problem hiding this comment.
Is there a way to not use a github action for a new linter? Ideally this one should go away in favor of a task that can be executed both locally and in CI.
There was a problem hiding this comment.
Hm - I'm being dumb... our check-generate-protobuf nix task which is already in ci runs linting under the connectproto directory already (which also does run locally).
It's actually unclear to me what this CI step is for - since it doesn't push the buf schema and just runs the linter.
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
joshua-kim
requested review from
StephenButtolph,
maru-ava,
meaghanfitzgerald and
rrazvan1
as code owners
|
Coreth branch: ava-labs/coreth#1047 |
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
|
This PR is being closed due to no activity. Please re-open if this needs to be prioritized. |
3 participants
Why this should be merged
We compile our buf modules seprately since the
protomodule doesn't want to compile stuff with theconnectplugin. This PR puts our buf modules under a common directory instead of separateprotoandconnectprotodirectories.How this works
Moves files
How this was tested
CI
Need to be documented in RELEASES.md?
No