This repository was archived by the owner on Dec 3, 2025. It is now read-only.
Contract - #894
Draft
geoff-vball wants to merge 1 commit into
Draft
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| * @param publicKey The new public key of the validator | ||
| */ | ||
| function updateValidator(uint256 validatorId, uint256 weight, bytes memory publicKey) public { | ||
| require(validatorId < validators.length, "Invalid validator ID"); |
Check notice
Code scanning / Semgrep PRO
Semgrep Finding: solidity.performance.use-custom-error-not-require.use-custom-error-not-require Note
| function getValidator( | ||
| uint256 validatorId | ||
| ) public view returns (Validator memory) { | ||
| require(validatorId < validators.length, "Invalid validator ID"); |
Check notice
Code scanning / Semgrep PRO
Semgrep Finding: solidity.performance.use-custom-error-not-require.use-custom-error-not-require Note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested
How is this documented