feat(instrumentation): otel collector#61
Open
ocdbytes wants to merge 13 commits into
Open
Conversation
ocdbytes
changed the title
vibhurajeev
reviewed
Mar 31, 2025
| old_nexus_headers: &HeaderStore, | ||
| txs: &Vec<Transaction>, | ||
| ) -> Result<(Option<TreeUpdateBatch>, StateUpdate, HashMap<H256, bool>), Error> { | ||
| self.block_number_metrics.number_of_transactions_batch.record(txs.len() as u64, &[]); |
Collaborator
There was a problem hiding this comment.
Can we do both of this, in lib.rs? state_machine is only supposed to be for pre_execution of batch ideally. We can add this to fn save_batch_information
Contributor
Author
There was a problem hiding this comment.
Here only one metrics is recorded is it ideal to create a function in lib ? If it was repeated then it should makes sense. wdyt ?
vibhurajeev
reviewed
Mar 31, 2025
|
|
||
| #[derive(Clone)] | ||
| pub struct ExecutionMetrics { | ||
| pub batch_execution_time: Histogram<u64>, |
Collaborator
There was a problem hiding this comment.
Can we rebase to vr/sequencing, so execution metrics and prover metrics can be separated.
vibhurajeev
reviewed
Apr 9, 2025
| echo "${HOME}/.risc0/bin" >> $GITHUB_PATH | ||
| # Need to install for specific version next. | ||
| ${HOME}/.risc0/bin/rzup install | ||
| ${HOME}/.risc0/bin/rzup install cargo-risczero 1.2.0 |
Contributor
Author
There was a problem hiding this comment.
yes. As I updated the risc 0 version we don't need to install the cargo components separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.