Skip to content

Fix bug where --extraInstances ignored standalone instance declarations - #307

Merged
riz0id merged 6 commits into
masterfrom
riz0id/extra-derived-instances
May 18, 2026
Merged

Fix bug where --extraInstances ignored standalone instance declarations#307
riz0id merged 6 commits into
masterfrom
riz0id/extra-derived-instances

Conversation

@riz0id

@riz0id riz0id commented May 14, 2026

Copy link
Copy Markdown
Collaborator

InstD was the type of declaration that was pick up by the --extraInstances mechanism, but DerivD is the constructor for standalone deriving declarations. This causes standalone deriving instance declarations to be ignored when splicing in extra instances with the --extraInstances flag.

@riz0id
riz0id requested a review from j6carey May 14, 2026 22:44
@riz0id riz0id self-assigned this May 14, 2026
Comment thread tests/Test/Proto/Generate/CodeGen.hs Outdated
Comment thread proto3-suite.cabal Outdated
Comment thread tests/Main.hs Outdated

@j6carey j6carey left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@riz0id
riz0id merged commit bb987ad into master May 18, 2026
48 checks passed
@riz0id
riz0id deleted the riz0id/extra-derived-instances branch May 18, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants