Change the functionality to allow filtering on a table and restrict elements from the filter - #17
Open
doolittlece wants to merge 3 commits into
Open
Change the functionality to allow filtering on a table and restrict elements from the filter#17doolittlece wants to merge 3 commits into
doolittlece wants to merge 3 commits into
Conversation
You can add an ignore to the options that allows the filter to ignore children that have that class. The ignore defaults to filter-ignore. To support this changed to use the jQuery.text() function.
Changed the .children to .contents to support text nodes.
Change to jQuery over $ in testing found that it was causing problems with other frameworks for example prototype. To be safe, change to use the jQuery instead of the $ alias
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a new input on the options ignore that allows you to ignore elements in a table using a class. The rest of the functionality stayed the same. The ignore defaults to the class filter-ignore but you can set it to any class you want. You just pass the class name in the options under the ignore like {ignore: 'a-class-to-ignore'}.