Fixes licenses issues that were hidden by bug in go-licenses - #1718
Merged
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
eks-distro-bot
added
the
size/L
jaxesn
force-pushed
the
jgw/fix-licenses-missed-by-bug
branch
4 times, most recently
from
January 11, 2023 21:32
439bb8e to
210f7c0
Compare
jaxesn
changed the title
jonathanmeier5
left a comment
jonathanmeier5
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Happy to lgtm once everyone's had a chance to have a look.
| $(FIX_LICENSES_AZURE_TARGET): | $(GO_MOD_DOWNLOAD_TARGETS) | ||
| # The azure sdk dependency github repo has a LICENSE however it does not have a go.mod | ||
| # checked in to the repo. Hence we need to manually download LICENSE from Github | ||
| # and place them in the vendor directory so that they is available for go-licenses to pick up |
Contributor
There was a problem hiding this comment.
nit: "they are" instead of "they is".
Contributor
|
/lgtm |
jaxesn
force-pushed
the
jgw/fix-licenses-missed-by-bug
branch
from
January 12, 2023 18:08
210f7c0 to
551f62c
Compare
Contributor
|
/lgtm |
nkvetsinski
pushed a commit
to nkvetsinski/eks-anywhere-build-tooling
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
There was a bug in go-licenses that was incorrectly matching licenses for modules in the vendor directory. Read the specifics in my upstream PR
. Using that PR I have run thru all the projects to confirm what was missed and updated the few spots that needed changes to make sure license files were in the correct locations. There was only a couple and they were similar situations we have seen before.
While getting the upstream PR thru I am going to update our builder-base to use my fork for the time being. This should be able to merge before that is officially rolled out, we just make see a bit of churn on the generated attribution files. I am going to try and time it up tho.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.