Make test suite finish faster - #320
Open
sarsko wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the test suite faster. The semaphore changes are quite interesting, as the only thing happening there is that we use the main thread for one of the tasks instead of spawning, which drastically cuts down on the number of schedules.
Slowest tests: before vs. after
mpsc_some_senders_with_blockingasync_mpsc_some_senders_with_blockingasync_mpsc_some_senders_with_blockingdropped_acquire_must_release_random(fair)batch_semaphore_test_2dropped_acquire_must_release_random(unfair)semtest_2ui(trybuild)async_mpsc_many_senders_with_blockingclock_condvar_notify_all_dfsruntime_mpsc_many_senders_with_blockingmpsc_recv_from_outside_runtimeSlowest single test: 77.8s → 22.7s (~3.4x faster). Combined top-6 time: 250.3s → 45.3s (~5.5x faster).
The
mpsc/semaphore tests that dominated the old tail are gone from the top 6 entirely.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.