fix(ci): improve Stellar network startup detection and timeout#1161
Open
AttissNgo wants to merge 3 commits into
Open
fix(ci): improve Stellar network startup detection and timeout#1161AttissNgo wants to merge 3 commits into
AttissNgo wants to merge 3 commits into
Conversation
- Increase timeout from 120s to 180s for slower CI runners - Add container status check before health polling - Improve response detection (check for 'friendbot' or 'status') - Add diagnostic output showing response and elapsed time - Dump container logs on timeout for debugging
isi8787
reviewed
Nov 12, 2025
milapsheth
reviewed
Nov 13, 2025
| echo "✅ Stellar Network is ready" | ||
| exit 0 | ||
|
|
||
| if curl -s "${{ steps.env.outputs.friendbot }}" | grep -q '"status"\|"friendbot"'; then |
Member
There was a problem hiding this comment.
Fix doesn't really make sense. Is the output now indicating friendbot as a readiness signifier? If so, then let's remove status? Otherwise behaviour needs to be understood and clarified in the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
how
Note
Increase wait robustness for local Stellar network (longer timeout, broader readiness check, better diagnostics) and include the setup action in CI path filters.
setup-stellar:MAX_WAITfrom120to180seconds and poll interval from2sto3s."status"or"friendbot".stellar network container logs local | tail -50on timeout.test-stellar.yaml:paths-filterto also watch.github/actions/setup-stellar/**so tests run when the action changes.Written by Cursor Bugbot for commit c57c4be. This will update automatically on new commits. Configure here.