feat(solana): add gasValue flag to GMP script#1366
Open
Deiadara wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d07dfdc. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

why
GMP Solana Scripts were missing auto gas payment
how
Note
Medium Risk
Adds an optional
PayGasinstruction and changesCallContracttransaction construction to bundle multiple instructions in one transaction, which could affect how transactions are serialized/signed and how gas is attributed/refunded.Overview
Adds
--gas-valueand optional--refund-addressto theCallContractCLI so GMP calls can atomically pay cross-chain gas in the same Solana transaction.Updates
build_transaction/call_contractto emit a two-instruction bundle (PayGasviasolana_axelar_gas_service+ gatewayCallContract) keyed by a keccakpayload_hash, with refund defaulting to the fee payer.Reviewed by Cursor Bugbot for commit 3634e78. Bugbot is set up for automated code reviews on this repo. Configure here.