Skip to content

[breaking] Use Babel 8 #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolo-ribaudo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[breaking] Use Babel 8 #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34d0b94
Use Babel 8
nicolo-ribaudo Mar 16, 2026
25d7e60
Fix type checking
nicolo-ribaudo Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion babel.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"sourceType": "unambiguous",
"presets": [
["@babel/preset-env", { "loose": true }],
"@babel/preset-env",
"@babel/preset-typescript"
],
"plugins": ["./scripts/babel-plugin-compat-core-import"],
Expand Down
16 changes: 8 additions & 8 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@
"watch": "gulp watch"
},
"devDependencies": {
"@babel/cli": "^7.28.6",
"@babel/core": "^7.28.6",
"@babel/eslint-parser": "^7.28.6",
"@babel/eslint-plugin-development": "^7.28.6",
"@babel/plugin-transform-runtime": "^7.28.5",
"@babel/preset-env": "^7.28.6",
"@babel/preset-typescript": "^7.28.5",
"@babel/runtime": "^7.28.6",
"@babel/cli": "^8.0.0-rc.3 <8.0.0",
"@babel/core": "^8.0.0-rc.3 <8.0.0",
"@babel/eslint-parser": "^8.0.0-rc.3 <8.0.0",
"@babel/eslint-plugin-development": "^8.0.0-rc.3 <8.0.0",
"@babel/plugin-transform-runtime": "^8.0.0-rc.3 <8.0.0",
"@babel/preset-env": "^8.0.0-rc.3 <8.0.0",
"@babel/preset-typescript": "^8.0.0-rc.3 <8.0.0",
"@babel/runtime": "^8.0.0-rc.3 <8.0.0",
"@rollup/plugin-babel": "^7.0.0",
"@rollup/plugin-json": "^6.1.0",
"@rollup/plugin-node-resolve": "^16.0.3",
Expand Down
16 changes: 8 additions & 8 deletions packages/babel-helper-define-polyfill-provider/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,19 @@
"./package.json": "./package.json"
},
"dependencies": {
"@babel/helper-compilation-targets": "^7.28.6",
"@babel/helper-plugin-utils": "^7.28.6",
"@babel/helper-compilation-targets": "^8.0.0-rc.3 <8.0.0",
"@babel/helper-plugin-utils": "^8.0.0-rc.3 <8.0.0",
"lodash.debounce": "^4.0.8"
},
"peerDependencies": {
"@babel/core": "^7.4.0 || ^8.0.0-0 <8.0.0"
"@babel/core": "^7.4.0 || ^8.0.0-rc.3"
},
"devDependencies": {
"@babel/cli": "^7.28.6",
"@babel/core": "^7.28.6",
"@babel/generator": "^7.28.6",
"@babel/plugin-transform-modules-commonjs": "^7.28.6",
"@babel/traverse": "^7.28.6",
"@babel/cli": "^8.0.0-rc.3 <8.0.0",
"@babel/core": "^8.0.0-rc.3 <8.0.0",
"@babel/generator": "^8.0.0-rc.3 <8.0.0",
"@babel/plugin-transform-modules-commonjs": "^8.0.0-rc.3 <8.0.0",
"@babel/traverse": "^8.0.0-rc.3 <8.0.0",
"@rollup/plugin-babel": "^7.0.0",
"babel-loader": "^10.1.0",
"rollup": "^4.59.0",
Expand Down
3 changes: 1 addition & 2 deletions packages/babel-helper-define-polyfill-provider/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import { declare } from "@babel/helper-plugin-utils";
import type { NodePath } from "@babel/traverse";

import _getTargets, {
import getTargets, {
isRequired,
getInclusionReasons,
} from "@babel/helper-compilation-targets";
const getTargets = _getTargets.default || _getTargets;

import { createUtilsGetter } from "./utils";
import ImportsCachedInjector from "./imports-injector";
Expand Down
3 changes: 1 addition & 2 deletions packages/babel-helper-define-polyfill-provider/test/helpers/ast-to-code-serializer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { types as t } from "@babel/core";
import _generator from "@babel/generator";
const generator = _generator.default;
import generator from "@babel/generator";

export default {
test: v => t.isNode(v),
Expand Down
20 changes: 10 additions & 10 deletions packages/babel-plugin-polyfill-corejs3/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,19 @@
"core-js-compat": "^3.48.0"
},
"devDependencies": {
"@babel/core": "^7.28.6",
"@babel/helper-plugin-test-runner": "^7.27.1",
"@babel/plugin-proposal-decorators": "^7.28.6",
"@babel/plugin-transform-class-properties": "^7.28.6",
"@babel/plugin-transform-classes": "^7.28.6",
"@babel/plugin-transform-for-of": "^7.27.1",
"@babel/plugin-transform-modules-commonjs": "^7.28.6",
"@babel/plugin-transform-runtime": "^7.28.5",
"@babel/plugin-transform-spread": "^7.28.6",
"@babel/core": "^8.0.0-rc.3 <8.0.0",
"@babel/helper-plugin-test-runner": "^8.0.0-rc.3 <8.0.0",
"@babel/plugin-proposal-decorators": "^8.0.0-rc.3 <8.0.0",
"@babel/plugin-transform-class-properties": "^8.0.0-rc.3 <8.0.0",
"@babel/plugin-transform-classes": "^8.0.0-rc.3 <8.0.0",
"@babel/plugin-transform-for-of": "^8.0.0-rc.3 <8.0.0",
"@babel/plugin-transform-modules-commonjs": "^8.0.0-rc.3 <8.0.0",
"@babel/plugin-transform-runtime": "^8.0.0-rc.3 <8.0.0",
"@babel/plugin-transform-spread": "^8.0.0-rc.3 <8.0.0",
"core-js": "^3.48.0",
"core-js-pure": "^3.48.0"
},
"peerDependencies": {
"@babel/core": "^7.4.0 || ^8.0.0-0 <8.0.0"
"@babel/core": "^7.4.0 || ^8.0.0-rc.3"
}
}
6 changes: 3 additions & 3 deletions packages/babel-plugin-polyfill-corejs3/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ export default defineProvider<Options>(function (
coreJSPureHelper("get-iterator", useBabelRuntime, ext),
"getIterator",
),
[node.object],
[node.object as t.Expression],
),
);
path.skip();
Expand Down Expand Up @@ -345,7 +345,7 @@ export default defineProvider<Options>(function (
parentPath.type === "OptionalMemberExpression"
? "MemberExpression"
: "CallExpression";
delete parentAsNotOptional.node.optional;
delete parentPath.node.optional;

({ parentPath } = parentPath);
} while (
Expand Down Expand Up @@ -400,7 +400,7 @@ export default defineProvider<Options>(function (
path.replaceWith(check(t.callExpression(id, [node.object])));
if (t.isOptionalMemberExpression(parent)) parent.optional = true;
} else {
path.replaceWith(t.callExpression(id, [node.object]));
path.replaceWith(t.callExpression(id, [node.object as t.Expression]));
}
}
},
Expand Down
6 changes: 5 additions & 1 deletion packages/babel-plugin-polyfill-corejs3/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,11 @@ export function maybeMemoizeContext(
context1 = t.cloneNode(object);
} else {
context2 = scope.generateDeclaredUidIdentifier("context");
context1 = t.assignmentExpression("=", t.cloneNode(context2), object);
context1 = t.assignmentExpression(
"=",
t.cloneNode(context2),
object as t.Expression,
);
}

return [context1, context2];
Expand Down
1 change: 1 addition & 0 deletions packages/babel-plugin-polyfill-corejs3/test/fixtures/absolute-imports/global/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"externalHelpers": false,
"targets": { "ie": "5" },
"plugins": [
[
"@@/polyfill-corejs3",
Expand Down
1 change: 1 addition & 0 deletions packages/babel-plugin-polyfill-corejs3/test/fixtures/absolute-imports/pure/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"externalHelpers": false,
"targets": { "ie": "5" },
"plugins": [
[
"@@/polyfill-corejs3",
Expand Down
5 changes: 4 additions & 1 deletion .../babel-plugin-polyfill-corejs3/test/fixtures/entry-global/actual-corejs-3.21/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@
"method": "entry-global"
}
]
]
],
"targets": {
"ie": "5"
}
}
4 changes: 0 additions & 4 deletions ...es/babel-plugin-polyfill-corejs3/test/fixtures/entry-global/actual-corejs-3.21/output.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,10 @@ import "core-js/modules/es.array-buffer.slice.js";
import "core-js/modules/es.data-view.js";
import "core-js/modules/es.date.get-year.js";
import "core-js/modules/es.date.now.js";
import "core-js/modules/es.date.set-year.js";
import "core-js/modules/es.date.to-gmt-string.js";
import "core-js/modules/es.date.to-iso-string.js";
import "core-js/modules/es.date.to-json.js";
import "core-js/modules/es.date.to-primitive.js";
import "core-js/modules/es.date.to-string.js";
import "core-js/modules/es.escape.js";
import "core-js/modules/es.function.bind.js";
import "core-js/modules/es.function.has-instance.js";
import "core-js/modules/es.function.name.js";
Expand Down Expand Up @@ -221,7 +218,6 @@ import "core-js/modules/es.typed-array.sort.js";
import "core-js/modules/es.typed-array.subarray.js";
import "core-js/modules/es.typed-array.to-locale-string.js";
import "core-js/modules/es.typed-array.to-string.js";
import "core-js/modules/es.unescape.js";
import "core-js/modules/es.weak-map.js";
import "core-js/modules/es.weak-set.js";
import "core-js/modules/esnext.array.from-async.js";
Expand Down
5 changes: 4 additions & 1 deletion .../babel-plugin-polyfill-corejs3/test/fixtures/entry-global/actual-corejs-3.25/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@
"method": "entry-global"
}
]
]
],
"targets": {
"ie": "5"
}
}
4 changes: 0 additions & 4 deletions ...es/babel-plugin-polyfill-corejs3/test/fixtures/entry-global/actual-corejs-3.25/output.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,10 @@ import "core-js/modules/es.array-buffer.slice.js";
import "core-js/modules/es.data-view.js";
import "core-js/modules/es.date.get-year.js";
import "core-js/modules/es.date.now.js";
import "core-js/modules/es.date.set-year.js";
import "core-js/modules/es.date.to-gmt-string.js";
import "core-js/modules/es.date.to-iso-string.js";
import "core-js/modules/es.date.to-json.js";
import "core-js/modules/es.date.to-primitive.js";
import "core-js/modules/es.date.to-string.js";
import "core-js/modules/es.escape.js";
import "core-js/modules/es.function.bind.js";
import "core-js/modules/es.function.has-instance.js";
import "core-js/modules/es.function.name.js";
Expand Down Expand Up @@ -228,7 +225,6 @@ import "core-js/modules/es.typed-array.sort.js";
import "core-js/modules/es.typed-array.subarray.js";
import "core-js/modules/es.typed-array.to-locale-string.js";
import "core-js/modules/es.typed-array.to-string.js";
import "core-js/modules/es.unescape.js";
import "core-js/modules/es.weak-map.js";
import "core-js/modules/es.weak-set.js";
import "core-js/modules/esnext.array.from-async.js";
Expand Down
5 changes: 4 additions & 1 deletion .../babel-plugin-polyfill-corejs3/test/fixtures/entry-global/actual-corejs-3.27/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@
"method": "entry-global"
}
]
]
],
"targets": {
"ie": "5"
}
}
4 changes: 0 additions & 4 deletions ...es/babel-plugin-polyfill-corejs3/test/fixtures/entry-global/actual-corejs-3.27/output.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,10 @@ import "core-js/modules/es.array-buffer.slice.js";
import "core-js/modules/es.data-view.js";
import "core-js/modules/es.date.get-year.js";
import "core-js/modules/es.date.now.js";
import "core-js/modules/es.date.set-year.js";
import "core-js/modules/es.date.to-gmt-string.js";
import "core-js/modules/es.date.to-iso-string.js";
import "core-js/modules/es.date.to-json.js";
import "core-js/modules/es.date.to-primitive.js";
import "core-js/modules/es.date.to-string.js";
import "core-js/modules/es.escape.js";
import "core-js/modules/es.function.bind.js";
import "core-js/modules/es.function.has-instance.js";
import "core-js/modules/es.function.name.js";
Expand Down Expand Up @@ -228,7 +225,6 @@ import "core-js/modules/es.typed-array.sort.js";
import "core-js/modules/es.typed-array.subarray.js";
import "core-js/modules/es.typed-array.to-locale-string.js";
import "core-js/modules/es.typed-array.to-string.js";
import "core-js/modules/es.unescape.js";
import "core-js/modules/es.weak-map.js";
import "core-js/modules/es.weak-set.js";
import "core-js/modules/esnext.suppressed-error.constructor.js";
Expand Down
5 changes: 4 additions & 1 deletion .../babel-plugin-polyfill-corejs3/test/fixtures/entry-global/actual-corejs-3.28/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@
"method": "entry-global"
}
]
]
],
"targets": {
"ie": "5"
}
}
4 changes: 0 additions & 4 deletions ...es/babel-plugin-polyfill-corejs3/test/fixtures/entry-global/actual-corejs-3.28/output.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,10 @@ import "core-js/modules/es.array-buffer.slice.js";
import "core-js/modules/es.data-view.js";
import "core-js/modules/es.date.get-year.js";
import "core-js/modules/es.date.now.js";
import "core-js/modules/es.date.set-year.js";
import "core-js/modules/es.date.to-gmt-string.js";
import "core-js/modules/es.date.to-iso-string.js";
import "core-js/modules/es.date.to-json.js";
import "core-js/modules/es.date.to-primitive.js";
import "core-js/modules/es.date.to-string.js";
import "core-js/modules/es.escape.js";
import "core-js/modules/es.function.bind.js";
import "core-js/modules/es.function.has-instance.js";
import "core-js/modules/es.function.name.js";
Expand Down Expand Up @@ -235,7 +232,6 @@ import "core-js/modules/es.typed-array.to-reversed.js";
import "core-js/modules/es.typed-array.to-sorted.js";
import "core-js/modules/es.typed-array.to-string.js";
import "core-js/modules/es.typed-array.with.js";
import "core-js/modules/es.unescape.js";
import "core-js/modules/es.weak-map.js";
import "core-js/modules/es.weak-set.js";
import "core-js/modules/esnext.suppressed-error.constructor.js";
Expand Down
5 changes: 4 additions & 1 deletion .../babel-plugin-polyfill-corejs3/test/fixtures/entry-global/actual-corejs-3.29/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@
"method": "entry-global"
}
]
]
],
"targets": {
"ie": "5"
}
}
4 changes: 0 additions & 4 deletions ...es/babel-plugin-polyfill-corejs3/test/fixtures/entry-global/actual-corejs-3.29/output.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,10 @@ import "core-js/modules/es.array-buffer.slice.js";
import "core-js/modules/es.data-view.js";
import "core-js/modules/es.date.get-year.js";
import "core-js/modules/es.date.now.js";
import "core-js/modules/es.date.set-year.js";
import "core-js/modules/es.date.to-gmt-string.js";
import "core-js/modules/es.date.to-iso-string.js";
import "core-js/modules/es.date.to-json.js";
import "core-js/modules/es.date.to-primitive.js";
import "core-js/modules/es.date.to-string.js";
import "core-js/modules/es.escape.js";
import "core-js/modules/es.function.bind.js";
import "core-js/modules/es.function.has-instance.js";
import "core-js/modules/es.function.name.js";
Expand Down Expand Up @@ -235,7 +232,6 @@ import "core-js/modules/es.typed-array.to-reversed.js";
import "core-js/modules/es.typed-array.to-sorted.js";
import "core-js/modules/es.typed-array.to-string.js";
import "core-js/modules/es.typed-array.with.js";
import "core-js/modules/es.unescape.js";
import "core-js/modules/es.weak-map.js";
import "core-js/modules/es.weak-set.js";
import "core-js/modules/esnext.suppressed-error.constructor.js";
Expand Down
5 changes: 4 additions & 1 deletion .../babel-plugin-polyfill-corejs3/test/fixtures/entry-global/actual-corejs-3.30/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@
"method": "entry-global"
}
]
]
],
"targets": {
"ie": "5"
}
}
4 changes: 0 additions & 4 deletions ...es/babel-plugin-polyfill-corejs3/test/fixtures/entry-global/actual-corejs-3.30/output.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,10 @@ import "core-js/modules/es.array-buffer.slice.js";
import "core-js/modules/es.data-view.js";
import "core-js/modules/es.date.get-year.js";
import "core-js/modules/es.date.now.js";
import "core-js/modules/es.date.set-year.js";
import "core-js/modules/es.date.to-gmt-string.js";
import "core-js/modules/es.date.to-iso-string.js";
import "core-js/modules/es.date.to-json.js";
import "core-js/modules/es.date.to-primitive.js";
import "core-js/modules/es.date.to-string.js";
import "core-js/modules/es.escape.js";
import "core-js/modules/es.function.bind.js";
import "core-js/modules/es.function.has-instance.js";
import "core-js/modules/es.function.name.js";
Expand Down Expand Up @@ -235,7 +232,6 @@ import "core-js/modules/es.typed-array.to-reversed.js";
import "core-js/modules/es.typed-array.to-sorted.js";
import "core-js/modules/es.typed-array.to-string.js";
import "core-js/modules/es.typed-array.with.js";
import "core-js/modules/es.unescape.js";
import "core-js/modules/es.weak-map.js";
import "core-js/modules/es.weak-set.js";
import "core-js/modules/esnext.suppressed-error.constructor.js";
Expand Down
5 changes: 4 additions & 1 deletion .../babel-plugin-polyfill-corejs3/test/fixtures/entry-global/actual-corejs-3.31/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@
"method": "entry-global"
}
]
]
],
"targets": {
"ie": "5"
}
}
4 changes: 0 additions & 4 deletions ...es/babel-plugin-polyfill-corejs3/test/fixtures/entry-global/actual-corejs-3.31/output.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,10 @@ import "core-js/modules/es.array-buffer.slice.js";
import "core-js/modules/es.data-view.js";
import "core-js/modules/es.date.get-year.js";
import "core-js/modules/es.date.now.js";
import "core-js/modules/es.date.set-year.js";
import "core-js/modules/es.date.to-gmt-string.js";
import "core-js/modules/es.date.to-iso-string.js";
import "core-js/modules/es.date.to-json.js";
import "core-js/modules/es.date.to-primitive.js";
import "core-js/modules/es.date.to-string.js";
import "core-js/modules/es.escape.js";
import "core-js/modules/es.function.bind.js";
import "core-js/modules/es.function.has-instance.js";
import "core-js/modules/es.function.name.js";
Expand Down Expand Up @@ -237,7 +234,6 @@ import "core-js/modules/es.typed-array.to-reversed.js";
import "core-js/modules/es.typed-array.to-sorted.js";
import "core-js/modules/es.typed-array.to-string.js";
import "core-js/modules/es.typed-array.with.js";
import "core-js/modules/es.unescape.js";
import "core-js/modules/es.weak-map.js";
import "core-js/modules/es.weak-set.js";
import "core-js/modules/esnext.suppressed-error.constructor.js";
Expand Down
5 changes: 4 additions & 1 deletion .../babel-plugin-polyfill-corejs3/test/fixtures/entry-global/actual-corejs-3.32/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@
"method": "entry-global"
}
]
]
],
"targets": {
"ie": "5"
}
}
Loading
Loading