Skip to content

fix: typos in documentation files #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kilavvy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: typos in documentation files #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c10728d
Update ParamsParser_test.go
kilavvy Mar 5, 2025
bf38eb5
Update verify-new-fp-offchain.sh
kilavvy Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bbn-test-4/finality-providers/scripts/verify-new-fp-offchain.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ for filePathRegistryFP in ${FP_CHANGED_FILES}; do
moniker=$(cat "$filePathRegistryFP" | jq -r '.description.moniker')
echo "fp moniker:" $moniker
if [ ${#moniker} -lt 3 ]; then
echo $moniker "has less than 3 characteres"
echo $moniker "has less than 3 characters"
exit 1
fi

securityContact=$(cat "$filePathRegistryFP" | jq -r '.description.security_contact')
echo "fp security_contact:" $securityContact
if [ ${#securityContact} -lt 4 ]; then
echo $securityContact "has less than 4 characteres"
echo $securityContact "has less than 4 characters"
exit 1
fi

Expand Down Expand Up @@ -75,4 +75,4 @@ for filePathRegistryFP in ${FP_CHANGED_FILES}; do
echo "stakercli check transaction"
FP_BTC_PK=$btcPk SIGNED_TX=$signedTx STAKERCLI_BIN=$STAKERCLI_BIN $CWD/fp-check-tx.sh
echo "✅ '${nickname}' is a valid fp offchain-registration"
done
done
2 changes: 1 addition & 1 deletion parameters/parser/ParamsParser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ func TestFailGlobalParamsValidation(t *testing.T) {
_, err = parser.NewParsedGlobalParamsFromFile(fileName)
assert.Equal(t, "invalid params with version 0: covenant quorum 6 cannot be more than the amount of covenants 5", err.Error())

// test invalid convenant pks
// test invalid covenant pks
deepCopy(&defaultGlobalParams, &clonedParams)
clonedParams.Versions[0].CovenantPks = []string{
"04ffeaec52a9b407b355ef6967a7ffc15fd6c3fe07de2844d61550475e7a5233e5",
Expand Down