fix: build review before hook in root build - #1389
Open
rNoz wants to merge 1 commit into
Open
Conversation
rNoz
marked this pull request as ready for review
August 25, 2026 11:01
Contributor
Author
|
Rebased this one-line build-order fix onto current Validation:
The PR still changes only the root |
rNoz
force-pushed
the
rnoz/fix-build-script-review-order
branch
from
August 28, 2026 21:47
5bc9215 to
171de7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1388.
Rationale
apps/hookcopies the review bundle during its build, so a clean checkout cannot run the rootbun run buildcommand when the review app has not already been built.Change scope
Update the root
package.jsonbuild script to runbuild:review, thenbuild:hook, thenbuild:opencode.Validation
On a clean Linux checkout with Bun,
bun install --frozen-lockfilecompleted,bun run build:reviewcompleted, and the correctedbun run buildcompleted.Explicit omissions
This change does not alter the hook build script, generated bundles, package dependencies, or runtime behavior. Generated
node_modulesanddistoutputs were removed after validation.