Skip to content

fix: build review before hook in root build - #1389

Open
rNoz wants to merge 1 commit into
backnotprop:mainfrom
rNoz:rnoz/fix-build-script-review-order
Open

fix: build review before hook in root build#1389
rNoz wants to merge 1 commit into
backnotprop:mainfrom
rNoz:rnoz/fix-build-script-review-order

Conversation

@rNoz

@rNoz rNoz commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Closes #1388.

Rationale

apps/hook copies the review bundle during its build, so a clean checkout cannot run the root bun run build command when the review app has not already been built.

Change scope

Update the root package.json build script to run build:review, then build:hook, then build:opencode.

Validation

On a clean Linux checkout with Bun, bun install --frozen-lockfile completed, bun run build:review completed, and the corrected bun run build completed.

Explicit omissions

This change does not alter the hook build script, generated bundles, package dependencies, or runtime behavior. Generated node_modules and dist outputs were removed after validation.

@rNoz
rNoz marked this pull request as ready for review August 25, 2026 11:01
@rNoz

rNoz commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Rebased this one-line build-order fix onto current main and reverified it from a clean checkout with no pre-existing review or hook bundles.

Validation:

  • PATH="$PWD/apps/hook/node_modules/.bin:$PATH" bun run typecheck passed (Bun's isolated linker does not expose a root tsc)
  • root bun run build passed after bun install --frozen-lockfile
  • full suite: 4,021 passed, 756 skipped, 3 failed locally; two failures passed in isolation, and the remaining combined-workspace-diff failure reproduced unchanged on a clean upstream/main checkout

The PR still changes only the root package.json build sequence: review, then hook, then OpenCode.

@rNoz
rNoz force-pushed the rnoz/fix-build-script-review-order branch from 5bc9215 to 171de7f Compare August 28, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Root build script runs dependent targets out of order

1 participant