Repin dictionarylib to db918324 (shared-list limit handling) - #242
Merged
Conversation
Picks up the fix for the debug-mode crash after a successful share: dialog TextEditingControllers are now disposed when the dialog subtree unmounts rather than one frame after pop, so the share dialog's exit animation can no longer touch a disposed controller. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UgDXJkwQ6nhbDr3P2z8q8y
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UgDXJkwQ6nhbDr3P2z8q8y
Same content as the previous pin — the branch was rebase-merged, so the commits got new SHAs on main and the pin must point at a ref that stays reachable after the branch is deleted. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UgDXJkwQ6nhbDr3P2z8q8y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repin only — no app-code changes. Neither app hardcodes the shared-list limits; it all lives in dictionarylib.
Picks up banool/dictionarylib#11, which handles the backend's new per-user list cap (100) and raised per-list entry cap (10000) from banool/dictionary_backend#2.
What that gets this app:
Verified
flutter pub get,flutter analyze lib/(no issues),flutter test(4 pass) against the repinned dictionarylib. Bothrefs moved together, as required.Note on the pin
db918324is the tip of dictionarylib'slist-limitsbranch, so this is pinned to an unmerged commit — deliberate, so the whole stack can be validated together. If banool/dictionarylib#11 is squash-merged the SHA changes and this needs repinning to the newmainSHA before merging.