Skip to content

Stub DNS in notification delivery tests #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robzolkos wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Stub DNS in notification delivery tests #2838

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18047ad
Stub DNS in notification delivery tests
robzolkos Apr 13, 2026
087b457
Clarify DNS stubbing in notification delivery tests
robzolkos Apr 13, 2026
076c2d9
Extract shared FCM DNS test helper
robzolkos Apr 14, 2026
3933826
Rename shared DNS test helper for web push
robzolkos Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/integration/notifications_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
require "test_helper"

class NotificationDeliveryTest < ActiveSupport::TestCase
Comment thread
robzolkos marked this conversation as resolved.
# Use a stable, publicly-routable IP so DNS stubbing satisfies public-host/SSRF
# validation for the FCM endpoint and remains deterministic across runs.
FCM_PUBLIC_TEST_IP = "142.250.185.206"
Comment thread
robzolkos marked this conversation as resolved.
Outdated

setup do
@assigner = users(:david)
@assignee = users(:kevin)
Expand All @@ -16,6 +20,8 @@ class NotificationDeliveryTest < ActiveSupport::TestCase
Notification.register_push_target(:web)
Notification.register_push_target(push_target_with_tracking)

stub_dns_resolution(FCM_PUBLIC_TEST_IP)

# Give assignee a web push subscription
@assignee.push_subscriptions.create!(
endpoint: "https://fcm.googleapis.com/fcm/send/test123",
Expand Down