Skip to content

Preserve ordered list starting number #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdiebolt wants to merge 4 commits into from
Closed

Preserve ordered list starting number #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
266a89e
Add 'start' to allowed HTML attributes in dom_purify
mdiebolt Jan 22, 2026
14ec469
build assets
mdiebolt Jan 22, 2026
523b92e
Resolve merge conflicts and rebuild assets
mdiebolt Jan 30, 2026
456e42e
Add start to ActionText allowlist
mdiebolt Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/assets/javascript/lexxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4681,7 +4681,7 @@ const ALLOWED_HTML_TAGS = [ "a", "b", "blockquote", "br", "code", "em",

const ALLOWED_HTML_ATTRIBUTES = [ "alt", "caption", "class", "content", "content-type", "contenteditable",
"data-direct-upload-id", "data-sgid", "filename", "filesize", "height", "href", "presentation",
"previewable", "sgid", "src", "style", "title", "url", "width" ];
"previewable", "sgid", "src", "start", "style", "title", "url", "width" ];

const ALLOWED_STYLE_PROPERTIES = [ "color", "background-color" ];

Expand Down
Binary file modified app/assets/javascript/lexxy.js.br
View file
Open in desktop
Binary file not shown.
Binary file modified app/assets/javascript/lexxy.js.gz
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion app/assets/javascript/lexxy.min.js
View file
Open in desktop

Large diffs are not rendered by default.

Binary file modified app/assets/javascript/lexxy.min.js.br
View file
Open in desktop
Binary file not shown.
Binary file modified app/assets/javascript/lexxy.min.js.gz
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion lib/lexxy/engine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class Engine < ::Rails::Engine
ActionText::ContentHelper.allowed_tags = default_allowed_tags + %w[ video audio source embed table tbody tr th td ]

default_allowed_attributes = Class.new.include(ActionText::ContentHelper).new.sanitizer_allowed_attributes
ActionText::ContentHelper.allowed_attributes = default_allowed_attributes + %w[ controls poster data-language style ]
ActionText::ContentHelper.allowed_attributes = default_allowed_attributes + %w[ controls poster data-language start style ]

Loofah::HTML5::SafeList::ALLOWED_CSS_FUNCTIONS << "var" # Allow CSS variables
end
Expand Down
2 changes: 1 addition & 1 deletion src/config/dom_purify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const ALLOWED_HTML_TAGS = [ "a", "b", "blockquote", "br", "code", "em",

const ALLOWED_HTML_ATTRIBUTES = [ "alt", "caption", "class", "content", "content-type", "contenteditable",
"data-direct-upload-id", "data-sgid", "filename", "filesize", "height", "href", "presentation",
"previewable", "sgid", "src", "style", "title", "url", "width" ]
"previewable", "sgid", "src", "start", "style", "title", "url", "width" ]

const ALLOWED_STYLE_PROPERTIES = [ "color", "background-color" ]

Expand Down