Add 'start' to allowed HTML attributes#782
Closed
adam-h wants to merge 1 commit intobasecamp:mainfrom
Closed
Conversation
In order for `ol` list elements to respect the numbers they were authored with we need to make sure that the `start` attribute makes it through dom_purify and the ActionText allowlist.
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures <ol start="…"> survives both DOMPurify and ActionText sanitization so authored ordered list numbering is preserved when loading HTML.
Changes:
- Added a system test asserting
startis retained on ordered lists. - Added
startto the DOMPurify allowed attribute list. - Added
startto ActionText’s allowed attributes in the engine initializer.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/system/load_html_test.rb | Adds coverage to confirm ol[start] is preserved when loading editor HTML. |
| src/config/dom_purify.js | Allows the start attribute through DOMPurify. |
| lib/lexxy/engine.rb | Allows the start attribute through ActionText’s sanitizer allowlist. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Apologies, this is a dupe #713 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order for
ollist elements to respect the numbers they were authored with we need to make sure that the start attribute makes it through dom_purify and the ActionText allowlist.