Skip to content

Prevent Safari Live Text selection on attachment images #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bergatron wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent Safari Live Text selection on attachment images #918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/assets/stylesheets/lexxy-content.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@
display: block;
margin-inline: auto;
max-inline-size: 100%;
-webkit-user-select: none;
user-select: none;
}

Expand Down
2 changes: 1 addition & 1 deletion src/nodes/action_text_attachment_upload_node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export class ActionTextAttachmentUploadNode extends ActionTextAttachmentNode {
}

#createDOMForImage() {
return createElement("img")
return createElement("img", { draggable: "false" })
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createElement assigns to DOM properties when the key exists on the element (see html_helper#createElement). Passing draggable: "false" sets img.draggable to a truthy value, which can keep dragging enabled. Use a boolean false here (consistent with ActionTextAttachmentNode).

Suggested change
return createElement("img", { draggable: "false" })
return createElement("img", { draggable: false })

Copilot uses AI. Check for mistakes.
}

#createDOMForFile() {
Expand Down
Loading