Open
Conversation
keith
requested review from
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
This was referenced Mar 25, 2026
Member
Author
|
i am also adding this new action name in #659, so i'll rebase whichever merges |
keith
force-pushed
the
ks/add-llvm-profdata-action-support-env
branch
from
5b60312 to
2ff7937
Compare
keith
commented
Apr 4, 2026
Comment on lines
+77
to
+80
| if cc_common.action_is_enabled( | ||
| feature_configuration = feature_configuration, | ||
| action_name = ACTION_NAMES.llvm_profdata, | ||
| ): |
Member
Author
There was a problem hiding this comment.
is there a different API I can use for this without having to force it to be enabled = True? without this calling these other functions fails ofc
Member
Author
There was a problem hiding this comment.
updated to automatically request that feature automatically instead
Having a real action name for llvm-profdata is helpful for fdo and for coverage. This change makes sure if a toolchain provides env for llvm-profdata, it is correctly used in fdo actions. Fixes bazelbuild#640
keith
force-pushed
the
ks/add-llvm-profdata-action-support-env
branch
from
2ff7937 to
a9b3259
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a real action name for llvm-profdata is helpful for fdo and for
coverage.
This change makes sure if a toolchain provides env for llvm-profdata, it
is correctly used in fdo actions.
Fixes #640