Skip to content

Add platform_mappings#1102

Closed
comius wants to merge 2 commits into
bazelbuild:masterfrom
comius:add-platform_mappings
Closed

Add platform_mappings#1102
comius wants to merge 2 commits into
bazelbuild:masterfrom
comius:add-platform_mappings

Conversation

@comius

@comius comius commented Sep 7, 2023

Copy link
Copy Markdown

This makes it possible to use C++ toolchains with rules_swift.

@comius

comius commented Sep 7, 2023

Copy link
Copy Markdown
Author

Blocked on: bazelbuild/bazel#17127

@keith

keith commented Sep 7, 2023

Copy link
Copy Markdown
Member

in the meantime we can probably either duplicate everything in the platform_mappings file to use the bzlmod identifier, or specify a different --platforms_mappings= with our bzlmod config on CI

@comius

comius commented Sep 7, 2023

Copy link
Copy Markdown
Author

in the meantime we can probably either duplicate everything in the platform_mappings file to use the bzlmod identifier

I tried using @apple_support in platform_mapping and even removing repo_name from MODULE.bazel and it just doesn't work

or specify a different --platforms_mappings= with our bzlmod config on CI

that I can do

@comius

comius commented Sep 7, 2023

Copy link
Copy Markdown
Author

Done

@keith

keith commented Sep 7, 2023

Copy link
Copy Markdown
Member

erm won't we need it to have content to support the other changes you're making in this job?

@comius

comius commented Sep 7, 2023

Copy link
Copy Markdown
Author

erm won't we need it to have content to support the other changes you're making in this job?

Sorry I’m not following. I’m just adding plaform mappings from rules_apple and disabling temporary for bzlmod. What other changes?

@keith

keith commented Sep 7, 2023

Copy link
Copy Markdown
Member

i mean are we going to have to un-disable for bzlmod very soon after you land bazelbuild/bazel#19441?

@comius

comius commented Sep 7, 2023

Copy link
Copy Markdown
Author

i mean are we going to have to un-disable for bzlmod very soon after you land bazelbuild/bazel#19441?

Correct. Yesterday I didn’t know it will be fixed so quickly. You can either merge this and I prepare a second pr, or I revert this one back to the old form. Whatever you prefer.

keith added a commit that referenced this pull request Sep 7, 2023
Replace #1102 with support
for bzlmod
@keith keith mentioned this pull request Sep 7, 2023
@keith

keith commented Sep 7, 2023

Copy link
Copy Markdown
Member

that PR is 9 months old, I submitted #1104 with the necessary changes to support bzlmod

@keith keith closed this Sep 7, 2023
keith added a commit that referenced this pull request Sep 7, 2023
Replace #1102 with support
for bzlmod
keith added a commit that referenced this pull request Sep 7, 2023
Replace #1102 with support
for bzlmod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants