Skip to content

[copilot] refactor OptimizelyPageMetrics notification listener to use… #13893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
HarveyPeachey wants to merge 11 commits into
base: WS-2284-fix-lost-view-events-in-optimizely
Choose a base branch
from
Draft

[copilot] refactor OptimizelyPageMetrics notification listener to use… #13893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
086ecc4
[copilot] refactor OptimizelyPageMetrics notification listener to use…
HarveyPeachey Apr 9, 2026
984909f
Merge branch 'WS-2284-fix-lost-view-events-in-optimizely' into WS-228…
louisearchibald Apr 15, 2026
ee0ead9
update bundlesize
louisearchibald Apr 15, 2026
c10fdb2
Merge branch 'WS-2284-fix-lost-view-events-in-optimizely-alt' of ssh:…
louisearchibald Apr 15, 2026
15287eb
fix failing test
louisearchibald Apr 15, 2026
1ae0def
Merge branch 'WS-2284-fix-lost-view-events-in-optimizely' into WS-228…
louisearchibald Apr 15, 2026
5752d57
update test names
louisearchibald Apr 15, 2026
4bf04c9
Merge branch 'WS-2284-fix-lost-view-events-in-optimizely-alt' of ssh:…
louisearchibald Apr 15, 2026
a0691bd
input test experiment details
louisearchibald Apr 15, 2026
cfa1854
addresses PR comment by adding optional chaining to decisionInfo
louisearchibald Apr 16, 2026
758385d
adds experiment name to activeExperiments array for article pages
louisearchibald Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/bundleSize/bundleSizeConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@
export const VARIANCE = 5;

export const MIN_SIZE = 935;
export const MAX_SIZE = 1309;
export const MAX_SIZE = 1439;
2 changes: 1 addition & 1 deletion src/app/components/OptimizelyPageMetrics/experimentsForPageMetrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const experimentsForPageMetrics: ExperimentsForPageTypeMetrics = [
{
// include tod2 so page-level metrics also fire on article pages for this experiment
pageType: ARTICLE_PAGE,
activeExperiments: ['newswb_ws_tod_article_2'],
activeExperiments: ['newswb_ws_tod_article_2', 'test_page_views_aa'],
},
{
// include media article pages so page metrics still count after clicking into a video page
Expand Down
Loading
Loading