WS-NA: Tidies E2E and Integration tests post NextJS migration#13912
Draft
Isabella-Mitchell wants to merge 4 commits intolatestfrom
Draft
WS-NA: Tidies E2E and Integration tests post NextJS migration#13912Isabella-Mitchell wants to merge 4 commits intolatestfrom
Isabella-Mitchell wants to merge 4 commits intolatestfrom
Conversation
| }); | ||
| // SKIPPED: The following tests have been skipped as the Error Page hasn't yet been migrated. | ||
| if ((envConfig as EnvironmentConfigType).standaloneErrorPages) { | ||
| // These tests are skipped because the Next.js application doesn't currently have dedicated routes for /{service}/404 and /{service}/500 that return HTTP 200. |
Contributor
Author
There was a problem hiding this comment.
Do we need these tests? If so I'll raise a tech ticket to support /404 and /500 routes on NextJS. Else I'll bin them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: WS-NA
Summary
Post NextJS migration tidy up. There were some tasks we left following the article page nextJS migration.
Code changes
Testing
Useful Links