Allow changing of properties mid-playback - #1
Open
firthm01 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was implemented for the offsetting controls, but the same mechanism can be used for other properties too.
The conversion/completion of metadata pulled from the native library is influenced by property values. We used to do this as soon as we received new metadata. Now the conversion is only done when it is required by another component (e.g, the BEAR renderer, or the dispatchLatestMetadata system).
However, since we can request this from multiple places (or in fact multiple times from the same component, as the BEAR renderer will do if the native library rejects the metadata), it doesn't make sense to convert it on every request - we should cache it. The issue then becomes if the properties which influence the conversion are modified in the meantime. To determine if the converted metadata is up-to-date, we version the property set, and store this version when we convert the metadata. This way we can compare the stored version with the version of the current property set to see if there is a mismatch, and reconvert the metadata if necessary.