Skip to content

Add the conda env file for python2 dev environment#43

Open
abhi18av wants to merge 1 commit intobebatut:masterfrom
biosharp-dotnet:feature/conda-environment
Open

Add the conda env file for python2 dev environment#43
abhi18av wants to merge 1 commit intobebatut:masterfrom
biosharp-dotnet:feature/conda-environment

Conversation

@abhi18av
Copy link
Copy Markdown

@abhi18av abhi18av commented Feb 7, 2020

Hi @bebatut,

First off, thanks for this package!

I was trying to find an automation tool for interacting with the ENA website and found this library. For now, I've created an environment_py2.yml via conda env for a consistent development environment.

It includes all the packages and the their dependencies.

@abhi18av
Copy link
Copy Markdown
Author

abhi18av commented Feb 7, 2020

I think the reason for failure for this test is simply because the ENA database has more data now. Please let me know if this assumption is correct and I'd update this test.

Regarding the tests, here is the status.

(enasearch_py2) Abhinavs-MacBook-Pro:enasearch eklavya$ make test
flake8 --exclude=.git,build --ignore=E501 .
py.test --cov=enasearch tests/
==================================================================================== test session starts ====================================================================================
platform darwin -- Python 2.7.15, pytest-3.2.2, py-1.8.1, pluggy-0.4.0
rootdir: /Users/eklavya/projects/code/ORG_biosharp_dotnet/enasearch, inifile:
plugins: cov-2.5.1
collected 30 items                                                                                                                                                                           

tests/test_cli.py ...............
tests/test_enasearch.py ..F............

---------- coverage: platform darwin, python 2.7.15-final-0 ----------
Name                    Stmts   Miss  Cover
-------------------------------------------
enasearch/__init__.py     280     82    71%
enasearch/__main__.py       5      5     0%
enasearch/cli.py          185      2    99%
-------------------------------------------
TOTAL                     470     89    81%


========================================================================================= FAILURES ==========================================================================================
_______________________________________________________________________________ test_get_search_result_number _______________________________________________________________________________

    def test_get_search_result_number():
        """Test get_search_result_number function"""
        nb = enasearch.get_search_result_number(
            free_text_search=False,
            query="tax_eq(10090)",
            result="assembly",
            need_check_result=True)
>       assert nb == 19
E       assert 21 == 19

tests/test_enasearch.py:41: AssertionError
=========================================================================== 1 failed, 29 passed in 721.32 seconds ===========================================================================
make: *** [test] Error 1

@abhi18av
Copy link
Copy Markdown
Author

abhi18av commented Feb 7, 2020

This environment file might also help us to update the testing mechanism on TravisCI since right now it is failing due to incompatible versions of Sphinx package
https://travis-ci.org/bebatut/enasearch/jobs/647439743?utm_medium=notification&utm_source=github_status

@bebatut
Copy link
Copy Markdown
Owner

bebatut commented Feb 11, 2020

Hi @abhi18av,

Thanks a lot for your pull request and for using this tool 😄

I just got a baby so I do not know when I will have time to have a look at it.

For the tests, you are probably right. They may need to be updated given changes on ENA. If you have some times to look at them, it would be awesome

@abhi18av
Copy link
Copy Markdown
Author

Hey @bebatut , first off congratulations 👶 👨‍👩‍👧 !

I completely understand about the priorities right now, no hurry here.

Just wanted to tell you that I'd probably be upgrading the tool to be installable in python3 conda environment and will be creating that PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants