builtin actor manager and scan interlock actor#877
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
624c3eb to
39a0d86
Compare
62018bb to
169d678
Compare
2f6e363 to
5fb164a
Compare
2d6f63a to
f2bb265
Compare
wakonig
left a comment
There was a problem hiding this comment.
The enabling / disabling logic seems to be broken: I tried to play around with the flags in a second client but it seems not work as expected.
Scenario I: I had the interlock enabled and triggered, a scan was pending. I disabled the interlock but the scan did not continue until the returned to a valid state.
Scenario II: I started with a disabled interlock actor and enabled it mid scan. I would expect that the scan is stopped and repeated but it simply continued without respecting the beamline state.
36964ab to
2e3da91
Compare
- separate pubsub channels for notifying the actor that a change is requested and notifying clients that a change has happened
b369f17 to
ca4c7db
Compare
ca4c7db to
7277c57
Compare
wakonig
left a comment
There was a problem hiding this comment.
works as expected!
As discussed offline, there are still some open points but I would suggest to merge it as is now and refine it in another PR to allow the widget development to proceed in the meantime.
f76f34b to
4099157
Compare
4099157 to
912e3f6
Compare
Adds a
BuiltinActorManagerin which we can run permanently-running hardcoded actors.Adds an implementation of such, a base BeamlineStateActor and a ScanInterlockActor which locks the primary queue when specified beamline states go out of range.