Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to check this a little more before merging, but this adds in the ability to check strings for length, or regex matching. It also lets you check that values are in a given list (or not in a given list). Should adress #30
Mainly though, it makes some underlying changes to how Wimsey tests work, were the tests can define their own logic to be executed on the dataframe (rather than currently, where they just say which descriptive stats like "count" they need).
I think that's got the potential to be really powerful, both for execution efficiency, but also for making development of complex tests a lot easier in Wimsey.
Like I said, want to do some more testing before merging this. . .