Skip to content

feat: enable scrolling for credential details content #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeMonkeyCoder wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: enable scrolling for credential details content #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/features/src/components/app-layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ import { useLocation } from "react-router-dom"

interface AppLayoutProps {
children: React.ReactNode
className?: string
}

export const AppLayout = ({ children }: AppLayoutProps) => {
export const AppLayout = ({ children, className }: AppLayoutProps) => {
const location = useLocation()
// biome-ignore lint: dependent just on location
useEffect(() => {
Expand All @@ -17,7 +18,10 @@ export const AppLayout = ({ children }: AppLayoutProps) => {
}
}, [location])
return (
<div className="flex flex-col flex-1 bg-background" data-testid="appLayout">
<div
className={`flex flex-col flex-1 bg-background ${className}`}
data-testid="appLayout"
>
{children}
</div>
)
Expand Down
22 changes: 14 additions & 8 deletions packages/features/src/credentials/views/credential-details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,22 @@ export const CredentialDetailsView = ({
}: CredentialDetailsViewProps) => {
const { t } = useTranslation()
return (
<AppLayout>
<MenuBar variant="back" onBackClicked={onGoBack} />
<section className="flex flex-col flex-1 justify-between px-8 pb-8 gap-8">
<h1 className="text-3xl w-full">{id}</h1>
<div className="break-all flex-1 p-4 bg-secondary rounded-xl whitespace-pre-wrap overflow-y-scroll">
<AppLayout className="h-screen">
<section className="flex flex-col justify-between w-full h-full pb-8">
<MenuBar variant="back" onBackClicked={onGoBack} />
<h1 className="text-3xl w-full px-8">{id}</h1>
<div className="break-all flex-1 p-4 bg-secondary rounded-xl whitespace-pre-wrap overflow-y-auto mx-8 mt-8">
{credential}
</div>
<button type="button" className="btn btn-error" onClick={onDelete}>
{t("credentials.delete")}
</button>
<div className="px-8 pt-8 w-full max-w-md self-center">
<button
type="button"
className="btn btn-error w-full"
onClick={onDelete}
>
{t("credentials.delete")}
</button>
</div>
</section>
</AppLayout>
)
Expand Down