ubus: do not reiterate bss_transition_request over each SSID - #269
Open
g0tar wants to merge 6 commits into
Open
Conversation
When having multiple SSIDs, bss_transition_request is sent for each one subscribed despite the fact, that ubus_invoke() is invoked using id not sub->id. This creates redundant copies of requests and BSS-TM-RESPs polluting air. Consider similar sanitization in del_client_interface().
Author
|
This fixes superfluous repetitions, but I'm not sure if the logic is proper here. Shouldn't his request be directed to kicking_ap only? What if client has just moved over to the better AP being other band on the same hostapd instance - it's going to be kicked again. Edit: apparently the ID here is in fact kicking_ap so the logic holds. |
The request is supposed to be send to kicking_ap only, no need to iterate over all SSIDs.
…tes list Client asked to move using absolute RSSI kicking (method 2) should have at least some candidate_ap (on kick_nr_list), otherwise the request is futile and only torments client having weak signal already. Do not waste air resources unless NR was deliberately disabled. If the client doesn't provide beacons using 802.1k we cannot really do anything *polite* to help it make handover decision, it's up to the device to recognize weak signal and search for something better.
g0tar
commented
Jun 16, 2026
| ubus_invoke(ctx, id, "bss_transition_request", b.head, NULL, NULL, timeout * 1000); | ||
| } | ||
| // do not ask to leave without providing candidates, unless NR explicitly disabled or unavailable (consider empty rrm_mode) | ||
| if (neighbors_added || (dawn_metric.disassoc_nr_length <= 0) || (dawn_metric.set_hostapd_nr <= 0) || (timeout_config.update_beacon_reports <= 0) ) { |
Author
There was a problem hiding this comment.
I wonder if update_beacon_reports condition shouldn't be coupled with set_hostapd_nr == 2, so that:
set_hostapd_nr '1'
update_beacon_reports '0'
with empty ap_nr_list won't spam either. I.e.
if (neighbors_added
|| (dawn_metric.disassoc_nr_length <= 0) || (dawn_metric.set_hostapd_nr <= 0)
|| ((timeout_config.update_beacon_reports <= 0) && (dawn_metric.set_hostapd_nr == 2)) ) {
…t with disabled 802.1k update_beacon_reports '0' shouldn't make difference for set_hostapd_nr '1'
Author
|
@PolynomialDivision, may I ask you for your opinion? |
Collaborator
|
I have to look closer again at this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When having multiple SSIDs, bss_transition_request is sent for each one subscribed despite the fact, that ubus_invoke() is invoked using id not sub->id.
This creates redundant copies of requests and BSS-TM-RESPs polluting the air.
Consider similar sanitization in del_client_interface().