Skip to content

datastorage: use RCPI when probe signal is unavailable #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PolynomialDivision merged 1 commit into from
Aug 10, 2026
Merged

datastorage: use RCPI when probe signal is unavailable #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/storage/datastorage.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include "dawn_iwinfo.h"
#include "dawn_uci.h"
#include "mac_utils.h"
#include "ieee80211_utils.h"

#include "datastorage.h"
#include "test_storage.h"
Expand Down Expand Up @@ -208,19 +209,27 @@ int get_band(int freq) {
int eval_probe_metric(struct probe_entry_s* probe_entry, ap* ap_entry) {
dawnlog_debug_func("Entering...");
int score = 0;
int signal = probe_entry->signal;
bool signal_available = signal != 0;

if (!signal_available && probe_entry->rcpi <= 220) {
signal = rcpi_to_rssi(probe_entry->rcpi);
signal_available = true;
dawnlog_trace("Scoring beacon report using RCPI %u as signal %d dBm\n",
probe_entry->rcpi, signal);
}

if (probe_entry->signal != 0)
if (signal_available)
{
dawn_mutex_require(&ap_array_mutex);
dawn_mutex_require(&probe_array_mutex);

// TODO: Should RCPI be used here as well?
int band = get_band(probe_entry->freq);
score = dawn_metric.initial_score[band];

score += probe_entry->signal >= dawn_metric.rssi_val[band] ? dawn_metric.rssi[band] : 0;
score += probe_entry->signal <= dawn_metric.low_rssi_val[band] ? dawn_metric.low_rssi[band] : 0;
score += (probe_entry->signal - dawn_metric.rssi_center[band]) * dawn_metric.rssi_weight[band];
score += signal >= dawn_metric.rssi_val[band] ? dawn_metric.rssi[band] : 0;
score += signal <= dawn_metric.low_rssi_val[band] ? dawn_metric.low_rssi[band] : 0;
score += (signal - dawn_metric.rssi_center[band]) * dawn_metric.rssi_weight[band];

// check if ap entry is available
if (ap_entry != NULL) {
Expand Down
Loading