Skip to content

let extract_source = builddir when more than one folders being extracted#138

Open
onesuper wants to merge 1 commit into
bernd:mainfrom
onesuper:extract_source_multiple
Open

let extract_source = builddir when more than one folders being extracted#138
onesuper wants to merge 1 commit into
bernd:mainfrom
onesuper:extract_source_multiple

Conversation

@onesuper

@onesuper onesuper commented Nov 9, 2015

Copy link
Copy Markdown

Hi,

Sometimes, a tar ball does not retain the parent directory. e.g. After type tar -xvf abc.tar.gz , there are some sub directories under the builddir like src, doc... instead of the abc folder.

The original code chooses the latest created folder after extraction to be the working directory for the building stage. I guess it makes more sense if we could return builddir to handle the above case (when more than one folders are extracted).

The new code return Dir.pwd directly, since already the working dir has been changed to builddir. And I make no changes to the tests since the change itself didn't break the test.

Regards
Yichao

@onesuper onesuper changed the title let extract_source to builddir when more than one dirs being extracted let extract_source = builddir when more than one dirs being extracted Nov 9, 2015
@onesuper onesuper changed the title let extract_source = builddir when more than one dirs being extracted let extract_source = builddir when more than one folders being extracted Nov 9, 2015
@onesuper

Copy link
Copy Markdown
Author

@bernd Not sure whether the change will affect other use case.

@bernd
bernd changed the base branch from master to main July 13, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant