Skip to content

Add ACCT to Manufacturers list#1097

Open
RunnyCow wants to merge 1 commit into
betaflight:masterfrom
RunnyCow:Branch_master
Open

Add ACCT to Manufacturers list#1097
RunnyCow wants to merge 1 commit into
betaflight:masterfrom
RunnyCow:Branch_master

Conversation

@RunnyCow
Copy link
Copy Markdown

@RunnyCow RunnyCow commented May 7, 2026

Description

This PR is a documentation-only update to the official Betaflight manufacturer ID list (Manufacturers.md). It adds a new manufacturer ID entry for Accton Technology Corporation (ACCT) to support workflows in the Betaflight Configurator.

  • Added Entry: ACCT (Accton Technology Corporation)
  • Contact URL: https://www.accton-iot.com
  • Placement: The new row has been inserted alphabetically between LEGA and AEDR to maintain order and file consistency.
  • Impact: No existing manufacturer entries or functional codes were modified or removed.

Contribution Type

  • Documentation / Website / Wiki / Translation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Hardware Compliance & Review Requirements

As this is a pure documentation asset change under the betaflight/config guidelines, full functional hardware validation and flight testing do not apply to this specific pull request.

  • Hardware Testing Status: N/A (No target firmware or hardware configuration profiles are introduced)
  • Applicable Guidelines: This pull request follows the standard peer-review and data accuracy validation process for Manufacturers.md list additions, rather than the functional hardware certification workflow required for new flight controller targets.

Checklist

  • My pull request is from a custom branch, not direct from master
  • Tested on hardware (N/A - Documentation only)
  • Follows coding style (N/A)
  • Updated documentation / manufacturer list
  • Verified target compilation (N/A)

Summary by CodeRabbit

  • New Features
    • Added support for Accton Technology Corporation as a manufacturer
    • Added G-FF4 flight controller board configuration with STM32F405 processor, motor control, sensor integration (accelerometer, gyro, barometer, magnetometer), and comprehensive I/O mapping

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a8d36d7f-07ea-440e-ad97-da2f575eb555

📥 Commits

Reviewing files that changed from the base of the PR and between 21d4c43 and d336430.

📒 Files selected for processing (1)
  • configs/G-FF4/config.h

Walkthrough

Adds a new Manufacturers.md row registering Accton Technology Corporation (ID ACCT) and adds a new board config header configs/G-FF4/config.h defining MCU, feature flags, pin mappings, peripheral instances, and board defaults.

Changes

Manufacturer Registry Update

Layer / File(s) Summary
Manufacturer Entry
Manufacturers.md
New table row for manufacturer id ACCT with name "Accton Technology Corporation" and contact URL https://www.accton-iot.com/.

G-FF4 Board Configuration

Layer / File(s) Summary
File header, identity, and feature macros
configs/G-FF4/config.h
Adds GPL header and board identity macros; sets target MCU, BOARD_NAME, MANUFACTURER_ID, and enables feature flags (ACC, GYRO, BARO, MAG, FLASH, MAX7456).
GPIO, motor, and sensor pin mappings
configs/G-FF4/config.h
Defines HW_VER, beeper, motor1–motor8 pins, gyro CS/INT/ALIGN, UART TX/RX pins, I2C1 SCL/SDA, LED pins, SPI1/SPI2/SPI3 mappings, flash and Max7456 CS pins, ADC VBAT/CURR, and TIMER_PIN_MAPPING.
Peripheral instances and board defaults
configs/G-FF4/config.h
Declares ADC/I2C/SPI instance constants, sensor I2C addresses and default baro address, default blackbox device, DShot/voltage/current meter defaults and scales, GPS/SerialRX UART and provider mappings, and HSE/clock instance settings.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • betaflight/config#838: Adds similar sensor-related configuration macros (USE_ACC_SPI_ICM42688P, USE_GYRO_SPI_ICM42688P, USE_BARO_DPS310) in another board config.

Suggested reviewers

  • ot0tot
  • sugaarK
  • osirisinferi
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change—adding ACCT (Accton Technology Corporation) to the Manufacturers list. It is concise, clear, and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RunnyCow
Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@RunnyCow
Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ot0tot
Copy link
Copy Markdown
Contributor

ot0tot commented May 12, 2026

We should wait to merge new manufacturers until they have an approved target under review as well

@sugaarK
Copy link
Copy Markdown
Member

sugaarK commented May 29, 2026

We should wait to merge new manufacturers until they have an approved target under review as well

agree

@sugaarK sugaarK added the Contact Betaflight Team cloudtargets@betaflight.com label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contact Betaflight Team cloudtargets@betaflight.com

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants