Add NWBLUE_PROH757 target#1108
Conversation
WalkthroughThis PR adds support for the NWBLUE manufacturer and its PROH757 STM32H757-based 30×30 multirotor flight controller by registering the manufacturer ID in the supported list and providing complete hardware configuration for the board, including MCU, sensors, peripherals, pin mappings, and default settings. ChangesNWBLUE Manufacturer and PROH757 Board Support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
configs/NWBLUE_PROH757/config.h (1)
161-190: 💤 Low valueMotor timer configuration looks good; consider clarifying MOTOR8 DMA limitation.
The TIMER_PIN_MAPPING is comprehensive and well-documented. Lines 187 and 189 correctly note that MOTOR6 and MOTOR8 lack dedicated DMA (hardware limitation of TIM4_CH4 and TIM3_CH4). Since the PR summary confirms bench testing with DSHOT bitbang OFF, this configuration is verified functional.
Minor enhancement: Line 189 (MOTOR8) could mirror line 187's comment style for consistency.
📝 Optional comment enhancement for consistency
- TIMER_PIN_MAP( 7, MOTOR8_PIN, 2, -1) /* TIM3_CH4 (occ 2) */ \ + TIMER_PIN_MAP( 7, MOTOR8_PIN, 2, -1) /* TIM3_CH4 (occ 2) - no DMA (UP shared) */ \🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@configs/NWBLUE_PROH757/config.h` around lines 161 - 190, The MOTOR8 TIMER_PIN_MAP comment should mirror MOTOR6's style to clarify the DMA limitation: update the TIMER_PIN_MAPPING entry referencing MOTOR8_PIN (TIMER_PIN_MAP index 7 / TIM3_CH4) to append a note like " - no DMA (UP shared)" or equivalent so it matches the wording used for MOTOR6_PIN (TIMER_PIN_MAP index 5) and makes the lack of dedicated DMA for TIM3_CH4 explicit and consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@configs/NWBLUE_PROH757/config.h`:
- Around line 161-190: The MOTOR8 TIMER_PIN_MAP comment should mirror MOTOR6's
style to clarify the DMA limitation: update the TIMER_PIN_MAPPING entry
referencing MOTOR8_PIN (TIMER_PIN_MAP index 7 / TIM3_CH4) to append a note like
" - no DMA (UP shared)" or equivalent so it matches the wording used for
MOTOR6_PIN (TIMER_PIN_MAP index 5) and makes the lack of dedicated DMA for
TIM3_CH4 explicit and consistent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 90109d1b-02b1-4ef2-b0d5-7655e493711d
📒 Files selected for processing (2)
Manufacturers.mdconfigs/NWBLUE_PROH757/config.h
| #define USE_MAG | ||
| #define USE_MAG_LIS2MDL |
There was a problem hiding this comment.
To prevent duplicate define (USE_MAG is also a build option and already pulls in all mag drivers)
| #define USE_MAG | |
| #define USE_MAG_LIS2MDL | |
| #ifndef USE_MAG | |
| #define USE_MAG | |
| #define USE_MAG_LIS2MDL | |
| #endif |
| TIMER_PIN_MAP( 4, MOTOR5_PIN, 1, 4) /* TIM4_CH3 */ \ | ||
| TIMER_PIN_MAP( 5, MOTOR6_PIN, 1, -1) /* TIM4_CH4 - no DMA (UP shared) */ \ | ||
| TIMER_PIN_MAP( 6, MOTOR7_PIN, 2, 5) /* TIM3_CH3 (occ 2) */ \ | ||
| TIMER_PIN_MAP( 7, MOTOR8_PIN, 2, -1) /* TIM3_CH4 (occ 2) */ \ |
There was a problem hiding this comment.
Did you mean SERVOx_PIN, servo's do not use dma.
|
is this for a commercial product? |
3 participants
Summary
Adds a new community flight-controller target: NWBLUE_PROH757, a 30×30 multirotor FC built on the CubePilot CubeNode H757 module (STM32H757 dual-core; Betaflight runs on M7, M4 left halted).
NWBL(NWBLUE, https://nwblue.com/) registered inManufacturers.mdconfigs/NWBLUE_PROH757/config.h:Test plan
make CONFIG=NWBLUE_PROH757GYRO_1_ALIGN CW0_DEG)Summary by CodeRabbit