chore: Ne plus charger les iframe#605
Draft
yann120 wants to merge 1 commit into
Draft
Conversation
yann120
commented
Jun 24, 2026
| def create_page | ||
| browser.create_page.tap do |page| | ||
| page.headers.set(request_headers) | ||
| page.network.blocklist = BLOCKED_URL_PATTERNS |
Collaborator
Author
There was a problem hiding this comment.
On ne peut pas mettre une blocklist en même temps qu'un page.network.intercept
Blocklist intercepte deja et accepte les requetes...
J'ai donc du re-ecrire ça sinon intercept fonctionnait pas
yann120
commented
Jun 24, 2026
| end | ||
|
|
||
| def block_unwanted_requests(page) | ||
| page.network.intercept(handle_auth_requests: false) |
Collaborator
Author
There was a problem hiding this comment.
On intercepte pas les requetes d'authentification, voir https://chromedevtools.github.io/devtools-protocol/tot/Fetch/#method-enable
https://github.com/rubycdp/ferrum/blob/9fae889c724ab4388bee2c5f54a440e0e095b86a/lib/ferrum/network.rb#L203
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ce changement bloque les iframe
Le resultat est positif sur des sites qui ont des iframe comme : http://fontenelle.fr/
Les iframe sont bien bloqué. Et le scraping prend moins d'une seconde au lieu de 30+ secondes
A tester sur main puis cette branche pour voir la différence