[SCHEMA] BEP028 - BIDS-Prov - #2098
Closed
bclenet wants to merge 23 commits into
Closed
Conversation
…re and Environments
effigies
reviewed
Jun 2, 2025
Comment on lines
+8
to
+17
| suffixes: | ||
| - act | ||
| - base | ||
| - ent | ||
| - env | ||
| - soft | ||
| extensions: | ||
| - .json | ||
| entities: | ||
| prov: required |
Collaborator
There was a problem hiding this comment.
So this should be permitting:
/prov/prov-<label>_act.json
/prov/prov-<label>_base.json
/prov/prov-<label>_ent.json
/prov/prov-<label>_env.json
/prov/prov-<label>_soft.json
This is the intent?
Contributor
Author
There was a problem hiding this comment.
We would like to allow:
/prov/[<subdirs>/]prov-<label>_act.json
/prov/[<subdirs>/]prov-<label>_ent.json
/prov/[<subdirs>/]prov-<label>_env.json
/prov/[<subdirs>/]prov-<label>_soft.json
(And I need to remove the base suffix)
Contributor
Author
There was a problem hiding this comment.
Also, is it ok to introduce the new src/schema/rules/files/common/modality_agnostic.yaml file in the schema ?
Is there something to do for this to be taken into account ?
Contributor
Author
Collaborator
|
I personally prefer to keep them together, since a good chunk of the spec is rendered from the schema. |
Contributor
Author
|
Modification were added in #2099 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress schema modification for the BEP028 - BIDS-Prov.