-
Notifications
You must be signed in to change notification settings - Fork 203
rf(schema): Make participants/sessions.tsv content available, add glob() and zip() functions #2359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
effigies
wants to merge
6
commits into
bids-standard:master
Choose a base branch
from
effigies:rf/tables
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9dc6637
feat(schema): Add glob and zip functions to expression language
effigies 37df2e4
feat(schema): Add dataset.{participants,sessions}_tsv to context
effigies 878bc4a
rf(schema): Rewrite rules to use new context, glob()
effigies 0708e30
rf(schema): Remove unused dataset.subjects from context
effigies 4b3fdef
test(schema): Add expression tests
effigies 46f2777
test(bst): Drop Subjects class from context types
effigies File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, in
I proposed to extend with
sessionsattribute here as to follow the summaries likedatatypesetc. I wonder if overall it makes sense to have both summaries and then access to particular crucial.tsvs because they seems to be complimentary as it was originalsubjectswhich would havesub_dirsand thus relating to actual data folders (thus beyond what is in the _tsv; and caching file system operations like glob).Or may be, if refactoring already and seems keeping them 'generic' "tsv files", make it into
tsv_filesthus making it possible to accommodate other files without changes to context schema, e.g.tsv_files["participants.tsv"]andtsv_files["sessions.tsv"]which could be complimented then withtsv_files["participant+sessions.tsv"]...btw is intention here to have
sessions_tsvappropriate for the folder, as e.g. undersub-Xto be thesub-X/sub-X_sessions.tsv(and whatever inheritance brings from the top levelsessions.tsv?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is specifically a top-level sessions.tsv file, as it goes in the
datasetcontext, which does not change as we walk over the file tree.Maybe we can talk over the design on some schema call?